From: Richard Henderson <rth@twiddle.net>
To: Ulrich Drepper <drepper@redhat.com>, Andreas Jaeger <aj@suse.de>,
GNU libc hacker <libc-hacker@sources.redhat.com>
Subject: Re: bug on mainline
Date: Sun, 03 Mar 2002 00:55:00 -0000 [thread overview]
Message-ID: <20020303005525.A13817@twiddle.net> (raw)
In-Reply-To: <20020303003323.A13743@twiddle.net>; from rth@twiddle.net on Sun, Mar 03, 2002 at 12:33:23AM -0800
On Sun, Mar 03, 2002 at 12:33:23AM -0800, Richard Henderson wrote:
> But the patch was supposed to generate proper bss symbols,
> not common symbols. Poke Kaveh for a start; I'll look at
> it if he doesn't take care of it.
Nevermind, I found it anyway.
r~
Index: c-decl.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/c-decl.c,v
retrieving revision 1.303
diff -u -p -r1.303 c-decl.c
--- c-decl.c 2002/02/28 13:29:47 1.303
+++ c-decl.c 2002/03/03 08:54:38
@@ -3476,7 +3476,7 @@ start_decl (declarator, declspecs, initi
initializer equal to zero. (Section 3.7.2)
-fno-common gives strict ANSI behavior. Usually you don't want it.
This matters only for variables with external linkage. */
- if (! flag_no_common || ! TREE_PUBLIC (decl))
+ if (!initialized && (! flag_no_common || ! TREE_PUBLIC (decl)))
DECL_COMMON (decl) = 1;
/* Set attributes here so if duplicate decl, will have proper attributes. */
next prev parent reply other threads:[~2002-03-03 8:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-02 22:41 Andreas Jaeger
2002-03-02 22:55 ` Ulrich Drepper
2002-03-03 0:33 ` Richard Henderson
2002-03-03 0:55 ` Richard Henderson [this message]
2002-03-03 1:15 ` Andreas Jaeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020303005525.A13817@twiddle.net \
--to=rth@twiddle.net \
--cc=aj@suse.de \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).