Re: local vs global self-reference in alpha/divrem.h

Re: local vs global self-reference in alpha/divrem.h

[Roland McGrath]

> On Sat, Jun 15, 2002 at 04:42:44PM -0400, Roland McGrath wrote:
> > By alpha binutils is from cvs some time last week.  Did something change
> > recently?  If not, I can't see how this ever worked for alpha-linux.
> 
> Yes, I changed the linker to catch more bugs of this form.
> This is exactly the sort of change that is needed.

Ok, I put that fix in.

local vs global self-reference in alpha/divrem.h

[Roland McGrath]

Before I made the following change, I was getting these errors when
attempting to link libc.so: 

/usr/local/lib/gcc-lib/alpha-gnu/3.1/../../../../alpha-gnu/bin/ld: /home/roland/gnu/build/alpha-libc/libc_pic.os: pc-relative relocation against dynamic symbol __divlu
/usr/local/lib/gcc-lib/alpha-gnu/3.1/../../../../alpha-gnu/bin/ld: /home/roland/gnu/build/alpha-libc/libc_pic.os: pc-relative relocation against dynamic symbol __divqu
/usr/local/lib/gcc-lib/alpha-gnu/3.1/../../../../alpha-gnu/bin/ld: /home/roland/gnu/build/alpha-libc/libc_pic.os: pc-relative relocation against dynamic symbol __remlu
/usr/local/lib/gcc-lib/alpha-gnu/3.1/../../../../alpha-gnu/bin/ld: /home/roland/gnu/build/alpha-libc/libc_pic.os: pc-relative relocation against dynamic symbol __remqu


By alpha binutils is from cvs some time last week.  Did something change
recently?  If not, I can't see how this ever worked for alpha-linux.

This change certainly seems harmless, but I didn't want to put it in
without a second opinion.


Index: divrem.h
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/alpha/divrem.h,v
retrieving revision 1.8
diff -u -p -b -r1.8 divrem.h
--- divrem.h	6 Jul 2001 04:55:45 -0000	1.8
+++ divrem.h	15 Jun 2002 20:35:34 -0000
@@ -1,4 +1,4 @@
-/* Copyright (C) 1996, 1997 Free Software Foundation, Inc.
+/* Copyright (C) 1996,97,2002 Free Software Foundation, Inc.
    Contributed by David Mosberger (davidm@cs.arizona.edu).
    This file is part of the GNU C Library.
 
@@ -86,6 +86,7 @@
 
 	.align 3
 UFUNC_NAME:
+$udiv_entry:
 	lda	sp, -STACK(sp)
 	.frame	sp, STACK, retaddr, 0
 #ifdef PROF
@@ -206,7 +207,7 @@ SFUNC_NAME:
 	cmovge	AT, AT, arg2
 
 	/* Do the unsigned division.  */
-	bsr	retaddr, UFUNC_NAME
+	bsr	retaddr, $udiv_entry
 
 	/* Restore originals and adjust the sign of the result.  */
 	ldq	arg1, 0(sp)