public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Kill 4 warnings
Date: Mon, 01 Jul 2002 04:48:00 -0000	[thread overview]
Message-ID: <20020701134806.N20867@sunsite.ms.mff.cuni.cz> (raw)

Hi!

Following patch fixes these warnings:

../iconv/skeleton.c:412: warning: unused variable `set'
tst-eof.c:19: warning: unused variable `tm'
tst-eof.c:18: warning: unused variable `ch'
Examples/ex9.c:35: warning: unused variable `th'

BTW: Shouldn't the linuxthreads testcases use test skeleton too, so that
if they hang (which is far more likely than in non-threaded tests) they
will be killed after timeout?

2002-07-01  Jakub Jelinek  <jakub@redhat.com>

	* libio/tst-eof.c (do_test): Remove unused ch and tm variables.
	* iconvdata/iso-2022-jp-3.c (EMIT_SHIFT_TO_INIT): Kill warnings if
	-DNDEBUG.

	* Examples/ex9.c (main): Remove unused th variable.

--- libc/iconvdata/iso-2022-jp-3.c.jj	Mon Jul  1 12:31:43 2002
+++ libc/iconvdata/iso-2022-jp-3.c	Mon Jul  1 13:53:09 2002
@@ -109,9 +109,8 @@ enum
 		    {							      \
 		      /* Write out the shift sequence before the last	      \
 			 character.  */					      \
-		      int set = data->__statep->__count & CURRENT_SEL_MASK;   \
-									      \
-		      assert (set == JISX0208_1983_set);		      \
+		      assert ((data->__statep->__count & CURRENT_SEL_MASK)    \
+			      == JISX0208_1983_set);			      \
 		      *outbuf++ = ESC;					      \
 		      *outbuf++ = '$';					      \
 		      *outbuf++ = 'B';					      \
--- libc/libio/tst-eof.c.jj	Tue Jun 25 21:32:08 2002
+++ libc/libio/tst-eof.c	Mon Jul  1 13:58:48 2002
@@ -15,8 +15,6 @@ do_test (void)
   char *buf;
   int fd;
   FILE *fp;
-  int ch;
-  char tm[20];
 
   buf = (char *) malloc (strlen (test_dir) + sizeof "/tst-eof.XXXXXX");
   if (buf == NULL)
--- libc/linuxthreads/Examples/ex9.c.jj	Mon Jul  1 12:31:53 2002
+++ libc/linuxthreads/Examples/ex9.c	Mon Jul  1 14:00:43 2002
@@ -32,7 +32,6 @@ static pthread_barrier_t barrier;
 int
 main (void)
 {
-  pthread_t th; 
   pthread_t thread_list[NUM_THREADS]; 
   int i;
 

	Jakub

             reply	other threads:[~2002-07-01 11:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-01  4:48 Jakub Jelinek [this message]
2002-07-10 20:00 ` Ulrich Drepper
2003-07-11 15:07 Jakub Jelinek
2003-07-11 22:50 ` Ulrich Drepper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020701134806.N20867@sunsite.ms.mff.cuni.cz \
    --to=jakub@redhat.com \
    --cc=drepper@redhat.com \
    --cc=libc-hacker@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).