public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Roland McGrath <roland@redhat.com>,
	Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix tst-timer (was Re: Some make check results)
Date: Sun, 29 Sep 2002 15:39:00 -0000	[thread overview]
Message-ID: <20020930003906.N3451@sunsite.ms.mff.cuni.cz> (raw)
In-Reply-To: <3D974495.4000901@redhat.com>; from drepper@redhat.com on Sun, Sep 29, 2002 at 11:21:09AM -0700

On Sun, Sep 29, 2002 at 11:21:09AM -0700, Ulrich Drepper wrote:
> I have put in your patch but I've also moved bug-erange from tests to
> xtests.  This goal was creates for just this purpose, tests which cannot
> generally be run but are still useful.

Thanks.

> > string/stratcliff failed on alpha/alphaev6/ia64
> 
> I've asked rth to review the strncpy patch...

That's alpha.
On IA-64 the following segfaults:
#include <sys/mman.h>
#include <string.h>
#include <stdlib.h>

char buf[128] __attribute__((aligned(128)));

int main (void)
{
  int i;
  char *p = mmap (NULL, 65536, PROT_READ, MAP_PRIVATE | MAP_ANON, -1, 0);
  if (p == NULL) abort ();
  memset (p + 65536 - 26, 'T', 26);
  strncpy (buf, p + 65536 - 26, 25);
}

Will debug it.

> > and tst-timer on ia64/i686 (both builds).
> 
> Don't know what that is.  Works for me.

tst-timer fails on sparc build too actually (well, there
it run for 3 hours until I killed that test, with exception of bug-regex12
all other tests succeeded).
On i686 and ia64 the reason is random value in sigev_notify_attributes.
It may well be 0 for you and you don't see the crash, for me it died on:
        newtimer->attr = *(pthread_attr_t *) evp->sigev_notify_attributes;
because evp->sigev_notify_attributes was garbage.
Will need to check sparc if that is the same reason or something else.

2002-09-29  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/pthread/tst-timer.c (main): Clear
	sigev2.sigev_notify_attributes.

--- linuxthreads/sysdeps/pthread/tst-timer.c.jj	2002-09-28 16:37:10.000000000 -0400
+++ linuxthreads/sysdeps/pthread/tst-timer.c	2002-09-29 18:30:42.000000000 -0400
@@ -76,6 +76,7 @@ main (void)
 
   sigev2.sigev_notify = SIGEV_THREAD;
   sigev2.sigev_notify_function = notify_func;
+  sigev2.sigev_notify_attributes = NULL;
 
   setvbuf (stdout, 0, _IOLBF, 0);
 

	Jakub

      reply	other threads:[~2002-09-29 22:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-29  6:55 Some make check results Jakub Jelinek
2002-09-29 11:21 ` Ulrich Drepper
2002-09-29 15:39   ` Jakub Jelinek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020930003906.N3451@sunsite.ms.mff.cuni.cz \
    --to=jakub@redhat.com \
    --cc=drepper@redhat.com \
    --cc=libc-hacker@sources.redhat.com \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).