From: Jakub Jelinek <jakub@redhat.com>
To: Roland McGrath <roland@redhat.com>, Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Honor executables DT_RUNPATH for dlopen
Date: Thu, 10 Oct 2002 23:42:00 -0000 [thread overview]
Message-ID: <20021010162155.Y3451@sunsite.ms.mff.cuni.cz> (raw)
Hi!
echo 'void f () {}' | gcc -fpic -shared -xc - -o libbar.so
gcc -Wl,-rpath,.,--enable-new-dtags -xc - -ldl -o bar <<"EOF"
#include <dlfcn.h>
int main () {
void *p = dlopen ("libbar.so", RTLD_NOW);
if (!p)
puts (dlerror ());
return !p;
}
EOF
./bar
test fails, because for dlopen DT_RUNPATH of the executable is not searched.
Unfortunately the patch does a bunch of tests in the common path, maybe
it should be reordered to check l->l_runpath_dirs.dirs != -1 right before
l->l_type != lt_loaded test.
2002-10-10 Jakub Jelinek <jakub@redhat.com>
* elf/dl-load.c (_dl_map_object): Use DT_RUNPATH of the executable
for dlopen searches.
--- libc/elf/dl-load.c.jj 2002-10-10 13:57:28.000000000 +0200
+++ libc/elf/dl-load.c 2002-10-10 13:59:20.000000000 +0200
@@ -1751,6 +1751,14 @@ _dl_map_object (struct link_map *loader,
break;
}
+ /* If dynamically linked, try the DT_RUNPATH of the executable
+ itself. */
+ l = GL(dl_loaded);
+ if (fd == -1 && l && l->l_type != lt_loaded && l != loader
+ && l->l_runpath_dirs.dirs != (void *) -1)
+ fd = open_path (name, namelen, preloaded, &l->l_runpath_dirs,
+ &realname, &fb);
+
if (fd == -1
&& (__builtin_expect (! preloaded, 1)
|| ! INTUSE(__libc_enable_secure)))
Jakub
next reply other threads:[~2002-10-10 14:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-10 23:42 Jakub Jelinek [this message]
2002-11-05 20:04 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021010162155.Y3451@sunsite.ms.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).