From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21111 invoked by alias); 14 Oct 2002 21:00:33 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 21093 invoked from network); 14 Oct 2002 21:00:32 -0000 Received: from unknown (HELO sunsite.mff.cuni.cz) (195.113.19.66) by sources.redhat.com with SMTP; 14 Oct 2002 21:00:32 -0000 Received: (from jakub@localhost) by sunsite.mff.cuni.cz (8.11.6/8.11.6) id g9EL0SU23510; Mon, 14 Oct 2002 23:00:28 +0200 Date: Mon, 14 Oct 2002 16:13:00 -0000 From: Jakub Jelinek To: Roland McGrath Cc: Ulrich Drepper , Glibc hackers Subject: Re: [PATCH] libc x86-64 __thread fix Message-ID: <20021014230027.H3451@sunsite.ms.mff.cuni.cz> Reply-To: Jakub Jelinek References: <20021014162717.G3451@sunsite.ms.mff.cuni.cz> <200210141937.g9EJbxx13170@magilla.sf.frob.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <200210141937.g9EJbxx13170@magilla.sf.frob.com>; from roland@redhat.com on Mon, Oct 14, 2002 at 12:37:59PM -0700 X-SW-Source: 2002-10/txt/msg00056.txt.bz2 On Mon, Oct 14, 2002 at 12:37:59PM -0700, Roland McGrath wrote: > Something is wrong if you need that. USE___THREAD != HAVE___THREAD. > Why is USE___THREAD defined in your rtld build? Actually, maybe just the #include is needed. The problem was that without including tls.h uname.os etc. in libc-pic.a was calling __errno_location(), which caused rtld-errno-loc.os to be added into librtld.a. But rtld-errno-loc.os would not compile, because errno was first defined as normal variable in include/errno.h and then redefined as __thread variable in sysdeps/generic/errno-loc.c. Though IMHO putting RTLD_PRIVATE_ERRNO case before USE__THREAD shouldn't hurt. Jakub