From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21902 invoked by alias); 14 Oct 2002 23:13:12 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 21886 invoked from network); 14 Oct 2002 23:13:12 -0000 Received: from unknown (HELO gateway.sf.frob.com) (64.163.215.223) by sources.redhat.com with SMTP; 14 Oct 2002 23:13:12 -0000 Received: from magilla.sf.frob.com (magilla.sf.frob.com [198.49.250.228]) by gateway.sf.frob.com (Postfix) with ESMTP id 413DE357E; Mon, 14 Oct 2002 16:13:11 -0700 (PDT) Received: (from roland@localhost) by magilla.sf.frob.com (8.11.6/8.11.6) id g9ENDAt13988; Mon, 14 Oct 2002 16:13:10 -0700 Date: Tue, 15 Oct 2002 00:36:00 -0000 Message-Id: <200210142313.g9ENDAt13988@magilla.sf.frob.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Jakub Jelinek Cc: Ulrich Drepper , Glibc hackers Subject: Re: [PATCH] libc x86-64 __thread fix In-Reply-To: Jakub Jelinek's message of Monday, 14 October 2002 23:00:27 +0200 <20021014230027.H3451@sunsite.ms.mff.cuni.cz> X-Zippy-Says: Why don't you ever enter any CONTESTS, Marvin?? Don't you know your own ZIPCODE? X-SW-Source: 2002-10/txt/msg00057.txt.bz2 > Actually, maybe just the #include is needed. Yes, though that doesn't directly affect the build of the rtld modules. > The problem was that without including tls.h uname.os etc. in libc-pic.a Ah, I see. I was confused as to how it could be losing even if USE___THREAD was never defined at all, because !defined -> 0 is the right default for the rtld build. But that explains it, since it was the libc build of the module that indirectly loused up the rtld build. > Though IMHO putting RTLD_PRIVATE_ERRNO case before USE__THREAD > shouldn't hurt. Certainly. I just don't like these things to be mysterious.