From: Roland McGrath <roland@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Andreas Schwab <schwab@suse.de>, libc-hacker@sources.redhat.com
Subject: Re: Bad alignment in locale-archive
Date: Tue, 22 Oct 2002 09:08:00 -0000 [thread overview]
Message-ID: <200210221604.g9MG4rJ14344@magilla.sf.frob.com> (raw)
In-Reply-To: Jakub Jelinek's message of Tuesday, 22 October 2002 16:25:29 +0200 <20021022162529.Z3451@sunsite.ms.mff.cuni.cz>
I put your version of the fix in, with a comment. (Please add comments in
the code for changes such as this. If it was nonobvious enough to have
missed when writing it the first time, it's nonbovious enough to warrant an
explanatory comment when reading the code.)
I agree that the alignment should always be 4. No extant architecture that
I know of needs more for these types (all structs containing uint32_t
members). OTOH, if __alignof__ ever reports more for some architecture and
we use 4, then we have a problem. From what we know now the files should
be portable modulo byte order, but no current configuration/installation
plan actually assumes they are (except maybe between 32/64 modes of bi-arch
platforms).
prev parent reply other threads:[~2002-10-22 16:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-22 7:00 Andreas Schwab
2002-10-22 7:29 ` Jakub Jelinek
2002-10-22 9:08 ` Roland McGrath [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200210221604.g9MG4rJ14344@magilla.sf.frob.com \
--to=roland@redhat.com \
--cc=jakub@redhat.com \
--cc=libc-hacker@sources.redhat.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).