From: Jakub Jelinek <jakub@redhat.com>
To: Roland McGrath <roland@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: init-first.c change
Date: Fri, 25 Oct 2002 12:42:00 -0000 [thread overview]
Message-ID: <20021025123831.P3451@sunsite.ms.mff.cuni.cz> (raw)
Hi!
I have doubts about:
2002-10-24 Roland McGrath <roland@redhat.com>
* sysdeps/unix/sysv/linux/init-first.c (init): Protect _dl_starting_up
access with [! SHARED].
* sysdeps/unix/sysv/aix/init-first.c (init): Likewise.
change. It seems to me that ATM all normal dynamically linked programs
will suddenly have __libc_multiple_libcs set to 1 while they had 0 there
previously. Shouldn't it actually be #ifdef SHARED?
Also:
/* The next variable is only here to work around a bug in gcc <= 2.7.2.2.
If the address would be taken inside the expression the optimizer
would try to be too smart and throws it away. Grrr. */
int *dummy_addr = &_dl_starting_up;
__libc_multiple_libcs = dummy_addr && !_dl_starting_up;
could be replaced with
__libc_multiple_libcs = &_dl_starting_up && !_dl_starting_up;
, because we don't support 2.7.2.2 any longer for glibc build.
Last, there is _dl_starting_up extern in elf/dl-init.c which could be
killed too.
Jakub
next reply other threads:[~2002-10-25 10:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-25 12:42 Jakub Jelinek [this message]
2002-10-25 17:33 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021025123831.P3451@sunsite.ms.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=libc-hacker@sources.redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).