From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11091 invoked by alias); 4 Nov 2002 09:32:54 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 11045 invoked from network); 4 Nov 2002 09:32:54 -0000 Received: from unknown (HELO Cantor.suse.de) (213.95.15.193) by sources.redhat.com with SMTP; 4 Nov 2002 09:32:54 -0000 Received: from Hermes.suse.de (Charybdis.suse.de [213.95.15.201]) by Cantor.suse.de (Postfix) with ESMTP id 6F8531449C; Mon, 4 Nov 2002 10:32:53 +0100 (MET) Date: Mon, 04 Nov 2002 01:32:00 -0000 From: Thorsten Kukuk To: Ulrich Drepper Cc: libc-hacker@sources.redhat.com Subject: Re: bits/libc-lock.h and _LIBC Message-ID: <20021104103253.A20309@suse.de> References: <20021021112734.A25309@suse.de> <3DC63DEA.7020101@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3DC63DEA.7020101@redhat.com> User-Agent: Mutt/1.3.22.1i Organization: SuSE Linux AG, Nuernberg, Germany X-SW-Source: 2002-11/txt/msg00006.txt.bz2 On Mon, Nov 04, Ulrich Drepper wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Thorsten Kukuk wrote: > > > We install libc-lock.h into /usr/include/bits. But libc-lock.h is > > only useable, if it is compiled with -D_LIBC, which breaks now with > > libio.h. > > What exactly fails? And when did it change? The header is in this form > installed on my systems and I have no problems using . The nss_db package, for example. libio.h uses some glibc internal things like attribute hidden, if _LIBC is defined, but without _LIBC defined, bits/libc-lock.h use useless. > > I suggest the following patch, or is there any reason for the > > ifdef _LIBC around __libc_lock_t ? We don't do this for __libc_key_t > > and all the other definitions. > > I've made the types opaque back when for a good reason. I think it was > mainly the use in libstdc++ but also to prevent any kind of initializers. Than do it for all or for nothing. If you currently wish to use libc-lock.h, you need to define _LIBC, but if you do this, you cannot include something, which includes libio.h, afterwards. The current bits/libc-lock.h behavior is inconsistent. Thorsten -- Thorsten Kukuk http://www.suse.de/~kukuk/ kukuk@suse.de SuSE Linux AG Deutschherrnstr. 15-19 D-90429 Nuernberg -------------------------------------------------------------------- Key fingerprint = A368 676B 5E1B 3E46 CFCE 2D97 F8FD 4E23 56C6 FB4B