From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13087 invoked by alias); 6 Nov 2002 08:58:12 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 13070 invoked from network); 6 Nov 2002 08:58:11 -0000 Received: from unknown (HELO gateway.sf.frob.com) (64.163.212.31) by sources.redhat.com with SMTP; 6 Nov 2002 08:58:11 -0000 Received: from magilla.sf.frob.com (magilla.sf.frob.com [198.49.250.228]) by gateway.sf.frob.com (Postfix) with ESMTP id 1E584357E; Wed, 6 Nov 2002 00:58:11 -0800 (PST) Received: (from roland@localhost) by magilla.sf.frob.com (8.11.6/8.11.6) id gA68wAE29263; Wed, 6 Nov 2002 00:58:10 -0800 Date: Wed, 06 Nov 2002 00:58:00 -0000 Message-Id: <200211060858.gA68wAE29263@magilla.sf.frob.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Ulrich Drepper Cc: GNU libc hackers Subject: Re: __builtin_frame_address vs %esp in pt-machine.h In-Reply-To: Ulrich Drepper's message of Friday, 18 October 2002 13:10:06 -0700 <3DB06A9E.40208@redhat.com> X-Antipastobozoticataclysm: When George Bush projectile vomits antipasto on the Japanese. X-SW-Source: 2002-11/txt/msg00012.txt.bz2 > Roland McGrath wrote: > > I don't understand this. Its use is to check whether another frame's auto > > variable address might be below (off the top) of the current stack. > > I've no time to think about the reason I had to make the change in the > moment. But I added this code to fix a bug. It is a necessary change. Bah! I searched all the logs and mailing list archives I could find and didn't see anything that would have explained the problem, like a related bug report around the time of the change. This is why you write comments in the code when there are nonobvious reasons for how it is! I still cannot imagine any reason why %esp would not be right for ptlongjmp.c's use (and any other).