From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17508 invoked by alias); 7 Nov 2002 22:27:37 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 17492 invoked from network); 7 Nov 2002 22:27:37 -0000 Received: from unknown (HELO gateway.sf.frob.com) (64.163.212.31) by sources.redhat.com with SMTP; 7 Nov 2002 22:27:37 -0000 Received: from magilla.sf.frob.com (magilla.sf.frob.com [198.49.250.228]) by gateway.sf.frob.com (Postfix) with ESMTP id 622C9357E; Thu, 7 Nov 2002 14:27:36 -0800 (PST) Received: (from roland@localhost) by magilla.sf.frob.com (8.11.6/8.11.6) id gA7MRZq29175; Thu, 7 Nov 2002 14:27:35 -0800 Date: Thu, 07 Nov 2002 14:27:00 -0000 Message-Id: <200211072227.gA7MRZq29175@magilla.sf.frob.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: davidm@hpl.hp.com Cc: libc-hacker@sources.redhat.com Subject: Re: [PATCH] move __gmon_start__ call out of .init section In-Reply-To: David Mosberger's message of Thursday, 7 November 2002 14:08:45 -0800 <15818.58477.531836.650663@napali.hpl.hp.com> X-Shopping-List: (1) Anatomic furniture aggressors (2) Would-be casinos (3) Eloquent inhibitions X-SW-Source: 2002-11/txt/msg00029.txt.bz2 > The problem is that the unwind info for the .init/.fini section will > be incorrect if it contains any function call. I don't really see why it should matter for these functions (when do you unwind through them?), but I can take your word for it that it does. > That's true, but .init is deprecated on ia64 anyhow. If legacy code > doesn't get profiled because it was using .init, I doubt that's a big > loss. Ok. > Perhaps the call could be moved into .preinit_array? I'm not entirely > sure whether that would be safe though. It's a weak reference and so might be zero. There is no provision in the spec for preinit_array elements being zero, so it would be questionable to have it skip them (rather than a user putting a random zero into the array getting the crash he deserves). It sounds like this is really an ia64-specific issue and so there isn't any question of wanting to do this for the other platforms. So I will put your change in. Please fix whatever you are using to munge your diffs so that it produces correct file names instead of the garbage all your recent patches have contained. After today I won't be in the mood to manually unmunge patches that can't be applied by any single -pN setting. Thanks, Roland