From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-hacker-return-5829-listarch-libc-hacker=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 28145 invoked by alias); 11 Nov 2002 08:48:53 -0000
Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:libc-hacker-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/libc-hacker/>
List-Post: <mailto:libc-hacker@sources.redhat.com>
List-Help: <mailto:libc-hacker-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: libc-hacker-owner@sources.redhat.com
Received: (qmail 28127 invoked from network); 11 Nov 2002 08:48:52 -0000
Received: from unknown (HELO gateway.sf.frob.com) (64.163.212.31)
  by sources.redhat.com with SMTP; 11 Nov 2002 08:48:52 -0000
Received: from magilla.sf.frob.com (magilla.sf.frob.com [198.49.250.228])
	by gateway.sf.frob.com (Postfix) with ESMTP
	id DCF15357E; Mon, 11 Nov 2002 00:48:51 -0800 (PST)
Received: (from roland@localhost)
	by magilla.sf.frob.com (8.11.6/8.11.6) id gAB8mp910445;
	Mon, 11 Nov 2002 00:48:51 -0800
Date: Mon, 11 Nov 2002 00:48:00 -0000
Message-Id: <200211110848.gAB8mp910445@magilla.sf.frob.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
From: Roland McGrath <roland@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: [PATCH] Speed up ___tls_get_addr
In-Reply-To: Jakub Jelinek's message of  Monday, 11 November 2002 08:37:43 +0100 <20021111083743.Z3451@sunsite.ms.mff.cuni.cz>
Emacs: the definitive fritterware.
X-SW-Source: 2002-11/txt/msg00051.txt.bz2

I think it is fine to put this in now, the dl-tls.c change that is.  (The
asm I would rather hold off on for now.)  But can you try internal_function
(i.e. regparm) on the new functions and see if that helps more?  Also the
function definitions should have comments mentioning why they should not be
inlined, etc.