From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10184 invoked by alias); 5 Dec 2002 23:00:18 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 10167 invoked from network); 5 Dec 2002 23:00:17 -0000 Received: from unknown (HELO sunsite.mff.cuni.cz) (195.113.19.66) by sources.redhat.com with SMTP; 5 Dec 2002 23:00:17 -0000 Received: (from jakub@localhost) by sunsite.mff.cuni.cz (8.11.6/8.11.6) id gB5N0DB17655; Fri, 6 Dec 2002 00:00:13 +0100 Date: Thu, 05 Dec 2002 15:00:00 -0000 From: Jakub Jelinek To: Roland McGrath , Ulrich Drepper Cc: Glibc hackers Subject: [PATCH] Fix sendfile on x86_64 Message-ID: <20021206000013.C1310@sunsite.ms.mff.cuni.cz> Reply-To: Jakub Jelinek Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i X-SW-Source: 2002-12/txt/msg00002.txt.bz2 Hi! On x86_64 it matters how many arguments one declares for syscall. sendfile has 3 args, scalar, scalar, pointer, scalar, yet it was declared as i:iip, which means %rcx was not moved to %r10. While at it, I've fixed a couple of other signatures too, full review would be good some time. 2002-12-05 Jakub Jelinek * sysdeps/unix/sysv/linux/x86_64/syscalls.list (sendfile): Change args to i:iipi. (readahead): Change args to i:iii. * sysdeps/unix/sysv/linux/powerpc/powerpc64/syscalls.list (readahead): Change args to i:iii. * sysdeps/unix/sysv/linux/mips/syscalls.list (readahead): Change args to i:iiii. --- libc/sysdeps/unix/sysv/linux/mips/syscalls.list.jj 2002-11-05 23:10:46.000000000 +0100 +++ libc/sysdeps/unix/sysv/linux/mips/syscalls.list 2002-12-06 01:16:52.000000000 +0100 @@ -66,7 +66,7 @@ s_pread64 pread64 pread i:ibniii __sysc s_putpmsg putpmsg putpmsg i:ippii __syscall_putpmsg s_ptrace ptrace ptrace i:iipp __syscall_ptrace s_pwrite64 pwrite64 pwrite i:ibniii __syscall_pwrite -s_readahead EXTRA readahead i:iipi __syscall_readahead +s_readahead EXTRA readahead i:iiii __syscall_readahead s_reboot reboot reboot i:iii __syscall_reboot s_setrlimit setrlimit setrlimit i:ip __syscall_setrlimit s_sigpending sigpending sigpending i:p __syscall_sigpending --- libc/sysdeps/unix/sysv/linux/powerpc/powerpc64/syscalls.list.jj 2002-10-14 09:29:05.000000000 +0200 +++ libc/sysdeps/unix/sysv/linux/powerpc/powerpc64/syscalls.list 2002-12-06 01:18:12.000000000 +0100 @@ -4,7 +4,7 @@ s_ioctl ioctl ioctl i:iiI __syscall_ioctl s_ipc msgget ipc i:iiiip __syscall_ipc s_llseek llseek _llseek i:iiipi __syscall__llseek -s_readahead readahead readahead i:iiii __syscall_readahead +s_readahead readahead readahead i:iii __syscall_readahead s_chown chown chown i:sii __syscall_chown s_execve execve execve i:spp __syscall_execve rt_sigaction - rt_sigaction i:ippi __syscall_rt_sigaction --- libc/sysdeps/unix/sysv/linux/x86_64/syscalls.list.jj 2002-12-06 01:03:38.000000000 +0100 +++ libc/sysdeps/unix/sysv/linux/x86_64/syscalls.list 2002-12-06 01:15:42.000000000 +0100 @@ -12,8 +12,8 @@ getrlimit - getrlimit i:ip __getrlimit g setrlimit - setrlimit i:ip __setrlimit setrlimit64 setrlimit ftruncate - ftruncate i:ii __ftruncate ftruncate ftruncate64 __ftruncate64 truncate - truncate i:si truncate truncate64 -readahead - readahead i:iipi __readahead readahead -sendfile - sendfile i:iip sendfile sendfile64 +readahead - readahead i:iii __readahead readahead +sendfile - sendfile i:iipi sendfile sendfile64 # semaphore and shm system calls msgctl - msgctl i:iip __msgctl msgctl Jakub