From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31249 invoked by alias); 10 Dec 2002 18:02:56 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 31212 invoked from network); 10 Dec 2002 18:02:53 -0000 Received: from unknown (HELO sunsite.mff.cuni.cz) (195.113.19.66) by sources.redhat.com with SMTP; 10 Dec 2002 18:02:53 -0000 Received: (from jakub@localhost) by sunsite.mff.cuni.cz (8.11.6/8.11.6) id gBAI2oE12652; Tue, 10 Dec 2002 19:02:50 +0100 Date: Tue, 10 Dec 2002 10:02:00 -0000 From: Jakub Jelinek To: Roland McGrath , Ulrich Drepper Cc: Glibc hackers Subject: [PATCH] Fix non-IA32 build Message-ID: <20021210190249.N1310@sunsite.ms.mff.cuni.cz> Reply-To: Jakub Jelinek Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i X-SW-Source: 2002-12/txt/msg00019.txt.bz2 Hi! Some __libc aliases were missing on various arches. I'm not sure if it is a good idea to export the new pthread wrappers @@GLIBC_2.3.1, because that will mean current programs/libs won't use the wrapped syscalls. IMHO it would be much better to export them at the versions they have in libc.so. select would be a slight problem, since it is usually select@@GLIBC_2.0, but on Alpha it is select@@GLIBC_2.1. 2002-12-10 Jakub Jelinek * include/libc-symbols.h: Fix a comment typo. * sysdeps/unix/sysv/linux/alpha/select.S (__libc_select): New alias. * sysdeps/unix/sysv/linux/alpha/sigsuspend.S (__libc_sigsuspend): Likewise. * sysdeps/unix/sysv/linux/ia64/sigsuspend.c (__libc_sigsuspend): Likewise. * sysdeps/unix/sysv/linux/s390/s390-64/sigsuspend.c (__libc_sigsuspend): Likewise. * sysdeps/unix/sysv/linux/sparc/sparc64/sigsuspend.c (__libc_sigsuspend): Likewise. * sysdeps/generic/creat.c (__libc_creat): Renamed from creat. (creat): New weak alias. --- libc/include/libc-symbols.h.jj 2002-11-05 23:10:07.000000000 +0100 +++ libc/include/libc-symbols.h 2002-12-10 17:36:24.000000000 +0100 @@ -655,7 +655,7 @@ There is no reason to use hidden_weak over hidden_def in assembly, but we provide it for consistency with the C usage. hidden_proto doesn't make sense for assembly but the equivalent - is to call via the HIDDEN_JUMPTARGET macro einstead of JUMPTARGET. */ + is to call via the HIDDEN_JUMPTARGET macro instead of JUMPTARGET. */ # define hidden_def(name) strong_alias (name, __GI_##name) # define hidden_weak(name) hidden_def (name) # define hidden_ver(local, name) strong_alias (local, __GI_##name) --- libc/sysdeps/unix/sysv/linux/alpha/select.S.jj 2002-11-08 11:39:46.000000000 +0100 +++ libc/sysdeps/unix/sysv/linux/alpha/select.S 2002-12-10 17:31:49.000000000 +0100 @@ -125,7 +125,9 @@ default_symbol_version (__select_tv64, _ strong_alias (__select_tv64, __select_tv64p) default_symbol_version (__select_tv64p, select, GLIBC_2.1) libc_hidden_ver (__select_tv64, __select) +strong_alias (__select_tv64, __libc_select) #else +strong_alias (__select, __libc_select) weak_alias (__select, select) libc_hidden_def (__select) #endif --- libc/sysdeps/unix/sysv/linux/alpha/sigsuspend.S.jj 2002-11-08 11:39:46.000000000 +0100 +++ libc/sysdeps/unix/sysv/linux/alpha/sigsuspend.S 2002-12-10 17:34:10.000000000 +0100 @@ -53,3 +53,4 @@ error: libc_hidden_def (__sigsuspend) weak_alias(__sigsuspend, sigsuspend) +strong_alias (__sigsuspend, __libc_sigsuspend) --- libc/sysdeps/unix/sysv/linux/ia64/sigsuspend.c.jj 2002-08-03 11:09:56.000000000 +0200 +++ libc/sysdeps/unix/sysv/linux/ia64/sigsuspend.c 2002-12-10 17:37:21.000000000 +0100 @@ -39,3 +39,4 @@ __sigsuspend (set) } libc_hidden_def (__sigsuspend) weak_alias (__sigsuspend, sigsuspend) +strong_alias (__sigsuspend, __libc_sigsuspend) --- libc/sysdeps/unix/sysv/linux/s390/s390-64/sigsuspend.c.jj 2002-08-03 11:09:58.000000000 +0200 +++ libc/sysdeps/unix/sysv/linux/s390/s390-64/sigsuspend.c 2002-12-10 17:37:52.000000000 +0100 @@ -38,3 +38,4 @@ __sigsuspend (set) } libc_hidden_def (__sigsuspend) weak_alias (__sigsuspend, sigsuspend) +strong_alias (__sigsuspend, __libc_sigsuspend) --- libc/sysdeps/unix/sysv/linux/sparc/sparc64/sigsuspend.c.jj 2002-08-03 11:09:59.000000000 +0200 +++ libc/sysdeps/unix/sysv/linux/sparc/sparc64/sigsuspend.c 2002-12-10 17:38:24.000000000 +0100 @@ -38,3 +38,4 @@ __sigsuspend (set) } libc_hidden_def (__sigsuspend) weak_alias (__sigsuspend, sigsuspend) +strong_alias (__sigsuspend, __libc_sigsuspend) --- libc/sysdeps/generic/creat.c.jj 2001-08-23 18:49:27.000000000 +0200 +++ libc/sysdeps/generic/creat.c 2002-12-10 18:09:16.000000000 +0100 @@ -23,9 +23,10 @@ /* Create FILE with protections MODE. */ int -creat (file, mode) +__libc_creat (file, mode) const char *file; mode_t mode; { return __open (file, O_WRONLY|O_CREAT|O_TRUNC, mode); } +weak_alias (__libc_creat, creat) Jakub