From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6909 invoked by alias); 29 Mar 2003 02:13:17 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 6893 invoked from network); 29 Mar 2003 02:13:16 -0000 Received: from unknown (HELO gateway.sf.frob.com) (64.160.55.131) by sources.redhat.com with SMTP; 29 Mar 2003 02:13:16 -0000 Received: from magilla.sf.frob.com (magilla.sf.frob.com [198.49.250.228]) by gateway.sf.frob.com (Postfix) with ESMTP id 81151354C; Fri, 28 Mar 2003 18:13:15 -0800 (PST) Received: (from roland@localhost) by magilla.sf.frob.com (8.11.6/8.11.6) id h2T2DEL01900; Fri, 28 Mar 2003 18:13:14 -0800 Date: Sat, 29 Mar 2003 02:26:00 -0000 Message-Id: <200303290213.h2T2DEL01900@magilla.sf.frob.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: kaz Kojima Cc: libc-hacker@sources.redhat.com Subject: Re: [PATCH] SH: atomic.h fixes In-Reply-To: kaz Kojima's message of Saturday, 29 March 2003 11:12:25 +0900 <200303290206.h2T26n812294@r-rr.iij4u.or.jp> X-Antipastobozoticataclysm: When George Bush projectile vomits antipasto on the Japanese. X-SW-Source: 2003-03/txt/msg00130.txt.bz2 Your current version looks like it still evaluates the macro arg VALUE twice in several macros. Also, I am not sure about using __typeof(value). Stick to __typeof(*(mem)) (and don't forget the parens around the macro arg), since the value might be a widened literal or something. I don't know SH at all, but I don't see anything that looks like system calls in here so I am confused by your comments.