From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30386 invoked by alias); 29 Mar 2003 02:36:21 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 30369 invoked from network); 29 Mar 2003 02:36:20 -0000 Received: from unknown (HELO r-rr.iij4u.or.jp) (210.130.0.76) by sources.redhat.com with SMTP; 29 Mar 2003 02:36:20 -0000 Received: from localhost (frgw.3in.ne.jp [210.251.121.226]) by r-rr.iij4u.or.jp (8.11.6+IIJ/8.11.6) with ESMTP id h2T2aI816005 for ; Sat, 29 Mar 2003 11:36:18 +0900 (JST) Message-Id: <200303290236.h2T2aI816005@r-rr.iij4u.or.jp> To: libc-hacker@sources.redhat.com Subject: Re: [PATCH] SH: atomic.h fixes In-Reply-To: Your message of "Fri, 28 Mar 2003 18:13:14 -0800" <200303290213.h2T2DEL01900@magilla.sf.frob.com> References: <200303290213.h2T2DEL01900@magilla.sf.frob.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Date: Sat, 29 Mar 2003 02:39:00 -0000 From: kaz Kojima X-Dispatcher: imput version 971024 X-SW-Source: 2003-03/txt/msg00132.txt.bz2 Roland McGrath wrote: > Your current version looks like it still evaluates the macro arg VALUE twice > in several macros. Also, I am not sure about using __typeof(value). > Stick to __typeof(*(mem)) (and don't forget the parens around the macro arg), > since the value might be a widened literal or something. I'd like to fix these points. Thanks. > I don't know SH at all, but I don't see anything that looks like system > calls in here so I am confused by your comments. Yes, there are no system calls. Please see . Regards, kaz