public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>, Roland McGrath <roland@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix get_proc_path
Date: Thu, 03 Apr 2003 11:02:00 -0000	[thread overview]
Message-ID: <20030403110213.GQ16629@sunsite.ms.mff.cuni.cz> (raw)

Hi!

atomic_compare_and_exchange_bool_acq returns non-zero if it failed to
exchange. This fixes getconf _NPROCESSORS_ONLN on my box.

2003-04-03  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/unix/sysv/linux/getsysstats.c (get_proc_path): Reverse test
	for atomic_compare_and_exchange_bool_acq failure.

--- libc/sysdeps/unix/sysv/linux/getsysstats.c.jj	2003-03-21 05:17:37.000000000 -0500
+++ libc/sysdeps/unix/sysv/linux/getsysstats.c	2003-04-03 05:31:09.000000000 -0500
@@ -85,7 +85,7 @@ get_proc_path (char *buffer, size_t bufs
 
   /* Now store the copied value.  But do it atomically.  */
   assert (sizeof (long int) == sizeof (void *__unbounded));
-  if (! atomic_compare_and_exchange_bool_acq (&mount_proc, copy_result, NULL))
+  if (atomic_compare_and_exchange_bool_acq (&mount_proc, copy_result, NULL))
     /* Replacing the value failed.  This means another thread was
        faster and we don't need the copy anymore.  */
     free (copy_result);

	Jakub

             reply	other threads:[~2003-04-03 11:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-03 11:02 Jakub Jelinek [this message]
2003-04-03 18:48 ` Ulrich Drepper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030403110213.GQ16629@sunsite.ms.mff.cuni.cz \
    --to=jakub@redhat.com \
    --cc=drepper@redhat.com \
    --cc=libc-hacker@sources.redhat.com \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).