From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>, Roland McGrath <roland@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix ppc32 INTERNAL_SYSCALL/INLINE_SYSCALL
Date: Wed, 21 May 2003 15:30:00 -0000 [thread overview]
Message-ID: <20030521153053.GF16629@sunsite.ms.mff.cuni.cz> (raw)
Hi!
ppc32/NPTL doesn't build ATM since nptl/unwind.c (unwind_cleanup)
uses INTERNAL_SYSCALL with string literal. Instead of adding (const char *)
forever to such uses, I think it is better to change ppc sysdep.h.
If an argument is a pointer type, no matter what sizeof tells it fits
into a single word register.
2003-05-21 Jakub Jelinek <jakub@redhat.com>
* sysdeps/unix/sysv/linux/powerpc/powerpc32/sysdep.h (LOADARGS_0,
LOADARGS_1, LOADARGS_2, LOADARGS_3, LOADARGS_4, LOADARGS_5,
LOADARGS_6): Don't error if syscall argument is a string literal.
--- libc/sysdeps/unix/sysv/linux/powerpc/powerpc32/sysdep.h.jj 2003-01-12 14:38:14.000000000 -0500
+++ libc/sysdeps/unix/sysv/linux/powerpc/powerpc32/sysdep.h 2003-05-21 09:22:43.000000000 -0400
@@ -117,32 +117,38 @@
# define LOADARGS_1(name, arg1) \
LOADARGS_0(name, 0); \
extern void __illegally_sized_syscall_##name##_arg1 (void); \
- if (sizeof (arg1) > 4) __illegally_sized_syscall_##name##_arg1 (); \
+ if (__builtin_classify_type (arg1) != 5 && sizeof (arg1) > 4) \
+ __illegally_sized_syscall_##name##_arg1 (); \
r3 = (long) (arg1)
# define LOADARGS_2(name, arg1, arg2) \
LOADARGS_1(name, arg1); \
extern void __illegally_sized_syscall_##name##_arg2 (void); \
- if (sizeof (arg2) > 4) __illegally_sized_syscall_##name##_arg2 (); \
+ if (__builtin_classify_type (arg2) != 5 && sizeof (arg2) > 4) \
+ __illegally_sized_syscall_##name##_arg2 (); \
r4 = (long) (arg2)
# define LOADARGS_3(name, arg1, arg2, arg3) \
LOADARGS_2(name, arg1, arg2); \
extern void __illegally_sized_syscall_##name##_arg3 (void); \
- if (sizeof (arg3) > 4) __illegally_sized_syscall_##name##_arg3 (); \
+ if (__builtin_classify_type (arg3) != 5 && sizeof (arg3) > 4) \
+ __illegally_sized_syscall_##name##_arg3 (); \
r5 = (long) (arg3)
# define LOADARGS_4(name, arg1, arg2, arg3, arg4) \
LOADARGS_3(name, arg1, arg2, arg3); \
extern void __illegally_sized_syscall_##name##_arg4 (void); \
- if (sizeof (arg4) > 4) __illegally_sized_syscall_##name##_arg4 (); \
+ if (__builtin_classify_type (arg4) != 5 && sizeof (arg4) > 4) \
+ __illegally_sized_syscall_##name##_arg4 (); \
r6 = (long) (arg4)
# define LOADARGS_5(name, arg1, arg2, arg3, arg4, arg5) \
LOADARGS_4(name, arg1, arg2, arg3, arg4); \
extern void __illegally_sized_syscall_##name##_arg5 (void); \
- if (sizeof (arg5) > 4) __illegally_sized_syscall_##name##_arg5 (); \
+ if (__builtin_classify_type (arg5) != 5 && sizeof (arg5) > 4) \
+ __illegally_sized_syscall_##name##_arg5 (); \
r7 = (long) (arg5)
# define LOADARGS_6(name, arg1, arg2, arg3, arg4, arg5, arg6) \
LOADARGS_5(name, arg1, arg2, arg3, arg4, arg5); \
extern void __illegally_sized_syscall_##name##_arg6 (void); \
- if (sizeof (arg6) > 4) __illegally_sized_syscall_##name##_arg6 (); \
+ if (__builtin_classify_type (arg6) != 5 && sizeof (arg6) > 4) \
+ __illegally_sized_syscall_##name##_arg6 (); \
r8 = (long) (arg6)
# define ASM_INPUT_0 "0" (r0)
Jakub
next reply other threads:[~2003-05-21 15:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-21 15:30 Jakub Jelinek [this message]
2003-05-21 19:04 ` [PATCH] Fix ppc32+ppc64 INTERNAL_SYSCALL/INLINE_SYSCALL Jakub Jelinek
2003-05-21 19:18 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030521153053.GF16629@sunsite.ms.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).