public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>,
	Paolo Bonzini <bonzini@gnu.org>,
	Isamu Hasegawa <isamu@yamato.ibm.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix regex \w and \W handling
Date: Tue, 17 Jun 2003 21:27:00 -0000	[thread overview]
Message-ID: <20030617212703.GL20507@sunsite.ms.mff.cuni.cz> (raw)

Hi!

At least according to info sed, info grep and previous regex implementation,
\w should be [_[:alnum:]], not [_[:alpha:]] as current glibc regex uses.
Couldn't find a word about \w/\W in POSIX 2003 though.

Also, info sed mentions \s and \S to match any whitespace (or
non-whitespace), but apparently current sed does not handle it (as it uses
glibc regex). This might clash with \sCLASS and \SCLASS in emacs regexs
(support for them was in old glibc regex.c #ifdef emacs).

2003-06-17  Jakub Jelinek  <jakub@redhat.com>

	* posix/regcomp.c (build_word_op): Use alnum instead of alpha class.

--- libc/posix/regcomp.c.jj	2003-06-16 14:26:20.000000000 -0400
+++ libc/posix/regcomp.c	2003-06-17 16:39:27.000000000 -0400
@@ -3341,7 +3341,7 @@ build_word_op (dfa, trans, not, err)
 #ifdef RE_ENABLE_I18N
 			 mbcset, &alloc,
 #endif /* RE_ENABLE_I18N */
-			 (const unsigned char *) "alpha", 0);
+			 (const unsigned char *) "alnum", 0);
 
   if (BE (ret != REG_NOERROR, 0))
     {

	Jakub

             reply	other threads:[~2003-06-17 21:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-17 21:27 Jakub Jelinek [this message]
2003-06-17 22:40 ` Ulrich Drepper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030617212703.GL20507@sunsite.ms.mff.cuni.cz \
    --to=jakub@redhat.com \
    --cc=bonzini@gnu.org \
    --cc=drepper@redhat.com \
    --cc=isamu@yamato.ibm.com \
    --cc=libc-hacker@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).