public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>, Roland McGrath <roland@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Add static_link_warning to dlopen
Date: Fri, 19 Sep 2003 20:36:00 -0000	[thread overview]
Message-ID: <20030919183448.GD12344@sunsite.ms.mff.cuni.cz> (raw)

Hi!

Using dlopen in statically linked apps has the same problems as using
NSS/iconv, so we should warn about it too.
Well, there might be an exception if the statically linked program
is dlopening libraries which are self-contained and don't need anything
from glibc (e.g. by using callbacks into the statically linked program),
but I guess it is so rare compared to the libs which actually need
libc that it should be warned always.

2003-09-19  Jakub Jelinek  <jakub@redhat.com>

	* dlfcn/dlopen.c (dlopen): Add static_link_warning.

--- libc/dlfcn/dlopen.c.jj	2001-07-06 00:54:45.000000000 -0400
+++ libc/dlfcn/dlopen.c	2003-09-19 16:08:44.000000000 -0400
@@ -54,3 +54,4 @@ __dlopen_check (const char *file, int mo
 }
 #include <shlib-compat.h>
 versioned_symbol (libdl, __dlopen_check, dlopen, GLIBC_2_1);
+static_link_warning (dlopen)

	Jakub

             reply	other threads:[~2003-09-19 20:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-19 20:36 Jakub Jelinek [this message]
2003-09-19 20:41 ` Ulrich Drepper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030919183448.GD12344@sunsite.ms.mff.cuni.cz \
    --to=jakub@redhat.com \
    --cc=drepper@redhat.com \
    --cc=libc-hacker@sources.redhat.com \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).