From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>, Roland McGrath <roland@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: [PATCH] Support LD_USE_LOAD_BIAS
Date: Sat, 22 Nov 2003 00:28:00 -0000 [thread overview]
Message-ID: <20031121221202.GV12344@sunsite.ms.mff.cuni.cz> (raw)
In-Reply-To: <20031121212053.GU12344@sunsite.ms.mff.cuni.cz>
Hi!
I think LD_USE_LOAD_BIAS shouldn't be honored for suid/sgid, as that way
a local attacker could disable randomization of a suid PIE and exploit it
more easily. This patch is on top of the previously posted one.
2003-11-22 Jakub Jelinek <jakub@redhat.com>
* elf/rtld.c (process_envvars): Only honor LD_USE_LOAD_BIAS
if !__libc_enable_secure.
--- libc/elf/rtld.c.jj 2003-11-21 23:46:17.000000000 +0100
+++ libc/elf/rtld.c 2003-11-22 01:12:55.000000000 +0100
@@ -2005,7 +2005,8 @@ process_envvars (enum mode *modep)
#ifdef EXTRA_LD_ENVVARS_13
EXTRA_LD_ENVVARS_13
#endif
- if (memcmp (envline, "USE_LOAD_BIAS", 13) == 0)
+ if (!INTUSE(__libc_enable_secure)
+ && memcmp (envline, "USE_LOAD_BIAS", 13) == 0)
GL(dl_use_load_bias) = envline[14] == '1' ? -1 : 0;
break;
Jakub
next prev parent reply other threads:[~2003-11-22 0:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-22 0:16 Jakub Jelinek
2003-11-22 0:28 ` Jakub Jelinek [this message]
2003-11-22 0:37 ` Roland McGrath
2003-11-22 0:44 ` Jakub Jelinek
2003-11-22 2:18 ` Roland McGrath
2003-11-22 3:01 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031121221202.GV12344@sunsite.ms.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).