public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
	Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: [PATCH] Small regexec.c fixes
Date: Mon, 29 Dec 2003 21:10:00 -0000	[thread overview]
Message-ID: <200312292110.hBTLAXW6012181@magilla.sf.frob.com> (raw)
In-Reply-To: Ulrich Drepper's message of  Monday, 29 December 2003 09:56:13 -0800 <3FF06ABD.6090300@redhat.com>

> I've applied the patch but in general we should avoid adding much code
> to free memory in case allocation fails.  Maybe to free some huge blocks
> but not more.  If the app runs out of memory it'll very soon terminate.
>  No need to bloat the code to help doing this.

I disagree completely.  It is important that library code never leak.  It
very well might be used in server situations where allocations can fail at
maximum load, or with unreasonable client input, but then enough more
memory gets freed by cleaning up resources associated with clients as they
die, that the server need never die.

      reply	other threads:[~2003-12-29 21:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-29 15:47 Jakub Jelinek
2003-12-29 17:58 ` Ulrich Drepper
2003-12-29 21:10   ` Roland McGrath [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200312292110.hBTLAXW6012181@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=drepper@redhat.com \
    --cc=jakub@redhat.com \
    --cc=libc-hacker@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).