public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Andreas Jaeger <aj@suse.de>
Cc: Ulrich Drepper <drepper@redhat.com>,
	Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: [PATCH] Fix AMD64 backtrace
Date: Mon, 12 Jan 2004 09:58:00 -0000	[thread overview]
Message-ID: <20040112075135.GT6413@sunsite.ms.mff.cuni.cz> (raw)
In-Reply-To: <m33candbth.fsf@gromit.moeb>

On Sat, Jan 10, 2004 at 05:10:18PM +0100, Andreas Jaeger wrote:
> --- sysdeps/unix/sysv/linux/x86_64/__start_context.S	27 Aug 2003 23:03:41 -0000	1.2
> +++ sysdeps/unix/sysv/linux/x86_64/__start_context.S	10 Jan 2004 16:09:40 -0000
> @@ -1,4 +1,4 @@
> -/* Copyright (C) 2002, 2003 Free Software Foundation, Inc.
> +/* Copyright (C) 2002, 2003, 2004 Free Software Foundation, Inc.
>     This file is part of the GNU C Library.
>     Contributed by Andreas Jaeger <aj@suse.de>, 2002.
>  
> @@ -33,6 +33,7 @@ ENTRY(__start_context)
>  	movq	%rbx, %rsp

This is not reflected in the unwind info.
Unless %rbx points to a populated stack with correct caller
something needs to be done about it.

> --- sysdeps/x86_64/strcspn.S	29 Apr 2003 22:47:18 -0000	1.2
> +++ sysdeps/x86_64/strcspn.S	10 Jan 2004 16:09:41 -0000
> @@ -1,7 +1,7 @@
>  /* strcspn (str, ss) -- Return the length of the initial segment of STR
>  			which contains no characters from SS.
>     For AMD x86-64.
> -   Copyright (C) 1994-1997, 2000, 2002, 2003 Free Software Foundation, Inc.
> +   Copyright (C) 1994-1997, 2000, 2002, 2003, 2004 Free Software Foundation, Inc.
>     This file is part of the GNU C Library.
>     Contributed by Ulrich Drepper <drepper@gnu.ai.mit.edu>.
>     Bug fixes by Alan Modra <Alan@SPRI.Levels.UniSA.Edu.Au>.
> @@ -40,6 +40,7 @@ ENTRY (strcspn)
>  	   table.  */
>  	movq %rdi, %r8			/* Save value.  */
>  	subq $256, %rsp			/* Make space for 256 bytes.  */
> +	cfi_adjust_cfa_offset(-256)

Typo/pasto.

	Jakub

  parent reply	other threads:[~2004-01-12  9:58 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-08 15:49 Jakub Jelinek
2004-01-08 18:24 ` Ulrich Drepper
2004-01-10 16:10 ` Andreas Jaeger
2004-01-10 18:07   ` Ulrich Drepper
2004-01-10 19:22     ` Andreas Jaeger
2004-01-10 19:24       ` Jakub Jelinek
2004-01-10 19:26         ` Andreas Jaeger
2004-01-10 19:27         ` Andreas Jaeger
2004-01-10 19:30       ` Ulrich Drepper
2004-01-10 19:51   ` Andreas Jaeger
2004-01-10 19:57     ` Jakub Jelinek
2004-01-10 20:13       ` Andreas Jaeger
2004-01-11 10:40         ` Andreas Jaeger
     [not found]           ` <20040111024737.A1431@redhat.com>
2004-01-11 10:50             ` Andreas Jaeger
     [not found]               ` <20040111025223.A2564@redhat.com>
2004-01-11 10:54                 ` Andreas Jaeger
2004-01-11 10:57                   ` Andreas Jaeger
     [not found]                     ` <20040111030005.C13258@redhat.com>
2004-01-11 12:16                       ` Andreas Jaeger
2004-01-11 12:17                       ` Andreas Jaeger
2004-01-11 18:50                         ` Jakub Jelinek
2004-01-11 19:28                           ` Andreas Jaeger
2004-01-11 20:13                             ` Jakub Jelinek
2004-01-11 20:19                               ` Andreas Jaeger
     [not found]                         ` <20040111202020.GB24540@redhat.com>
2004-01-11 20:31                           ` Andreas Jaeger
     [not found]                             ` <20040111213631.GD24540@redhat.com>
     [not found]                               ` <20040112231919.GB27775@nevyn.them.org>
     [not found]                                 ` <20040112155217.A30317@redhat.com>
2004-01-22  7:24                                   ` [rfc] dwarf2 backtrace from setcontext Andreas Jaeger
     [not found]                                     ` <20040122080350.GA18412@redhat.com>
2004-01-22  8:16                                       ` Andreas Jaeger
2004-01-12  9:58   ` Jakub Jelinek [this message]
2004-01-12 16:44     ` [PATCH] Fix AMD64 backtrace Andreas Jaeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040112075135.GT6413@sunsite.ms.mff.cuni.cz \
    --to=jakub@redhat.com \
    --cc=aj@suse.de \
    --cc=drepper@redhat.com \
    --cc=libc-hacker@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).