From: Jakub Jelinek <jakub@redhat.com>
To: davidm@hpl.hp.com
Cc: Roland McGrath <roland@redhat.com>,
GNU libc hackers <libc-hacker@sources.redhat.com>
Subject: Re: enabling caching for dl_iterate_phdr()
Date: Thu, 22 Jan 2004 08:39:00 -0000 [thread overview]
Message-ID: <20040122062944.GC6811@sunsite.ms.mff.cuni.cz> (raw)
In-Reply-To: <16399.6885.708290.614809@napali.hpl.hp.com>
On Wed, Jan 21, 2004 at 04:35:49PM -0800, David Mosberger wrote:
> --- elf/link.h 16 Sep 2003 05:48:04 -0000 1.76
> +++ elf/link.h 22 Jan 2004 00:26:54 -0000
> @@ -100,6 +100,12 @@
> const char *dlpi_name;
> const ElfW(Phdr) *dlpi_phdr;
> ElfW(Half) dlpi_phnum;
> +
> + /* Note: older versions of libc do not provide the following
> + members. Check the SIZE argument pass to the dl_iterate_phdr()
> + callback to determine whether or not they areprovided. */
> + unsigned int dlpi_adds; /* incremented when phdrs may have been added */
> + unsigned int dlpi_subs; /* incremented when phdrs may have been removed */
I'd make the counters unsigned long long instead to avoid wrap around.
Also, could you write a testcase for it? dl_iterate_phdr, then dlopen some
shlib in elf, then dl_iterate_phdr again, check the counters, dlclose
etc.
Jakub
next prev parent reply other threads:[~2004-01-22 8:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <16387.9755.753294.37588@napali.hpl.hp.com>
2004-01-17 0:57 ` Roland McGrath
2004-01-17 1:39 ` Jakub Jelinek
2004-01-17 1:40 ` Roland McGrath
2004-01-17 1:51 ` David Mosberger
2004-01-22 0:35 ` David Mosberger
2004-01-22 8:39 ` Jakub Jelinek [this message]
2004-01-24 5:54 ` David Mosberger
2004-01-24 20:27 ` Ulrich Drepper
2004-01-26 21:48 ` David Mosberger
2004-01-26 22:39 ` Ulrich Drepper
2004-01-26 22:58 ` Roland McGrath
2004-01-26 23:03 ` David Mosberger
2003-12-16 19:55 David Mosberger
2003-12-23 22:24 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040122062944.GC6811@sunsite.ms.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=davidm@hpl.hp.com \
--cc=libc-hacker@sources.redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).