From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32314 invoked by alias); 23 Mar 2004 20:37:07 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 32256 invoked from network); 23 Mar 2004 20:37:03 -0000 Received: from unknown (HELO sunsite.ms.mff.cuni.cz) (195.113.15.26) by sources.redhat.com with SMTP; 23 Mar 2004 20:37:03 -0000 Received: from sunsite.ms.mff.cuni.cz (sunsite.mff.cuni.cz [127.0.0.1]) by sunsite.ms.mff.cuni.cz (8.12.8/8.12.8) with ESMTP id i2NIRDHS003482; Tue, 23 Mar 2004 19:27:13 +0100 Received: (from jakub@localhost) by sunsite.ms.mff.cuni.cz (8.12.8/8.12.8/Submit) id i2NIRDXj003478; Tue, 23 Mar 2004 19:27:13 +0100 Date: Wed, 24 Mar 2004 00:04:00 -0000 From: Jakub Jelinek To: Ulrich Drepper Cc: Glibc hackers Subject: Re: [RFC PATCH] Kill some duplication between 64-bit linux arches Message-ID: <20040323182713.GG15946@sunsite.ms.mff.cuni.cz> Reply-To: Jakub Jelinek References: <20040323163053.GF15946@sunsite.ms.mff.cuni.cz> <40608773.4070401@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40608773.4070401@redhat.com> User-Agent: Mutt/1.4i X-SW-Source: 2004-03/txt/msg00125.txt.bz2 On Tue, Mar 23, 2004 at 10:52:35AM -0800, Ulrich Drepper wrote: > This patch is not valid under current assumptions. INLINE_SYSCALL is a > Linux-ism. It cannot be used in sysdeps/wordsize-64 which is a generic > directory. The problem is that what is a syscall on Linux need not > necessarily by a syscall equivalent on other OSes. Hurd, for instance, > has read() as a normal function in libc IIRC. > > Maybe creating sysdeps/unix/sysv/linux/wordsize-64, moving the new files > there, and requiring that directory for all 64-bit archs on Linux will work. But that is exactly what this patch is doing: ... * sysdeps/unix/sysv/linux/wordsize-64/statvfs64.c: New file. ... other 29 files in that new directory. Jakub