From: Thorsten Kukuk <kukuk@suse.de>
To: libc-hacker@sources.redhat.com
Subject: Re: NSS modules and errno if key not found
Date: Mon, 29 Mar 2004 20:16:00 -0000 [thread overview]
Message-ID: <20040327175122.GA21826@suse.de> (raw)
In-Reply-To: <20040326221341.GA14167@suse.de>
On Fri, Mar 26, Thorsten Kukuk wrote:
>
> Hi,
>
> I found a problem today when debugging some NSS releated problems.
>
> If somebody calls getgrnam_r (or any other reentrant NSS function),
> the return value of the function will be errno if the status is not
> NSS_STATUS_SUCCESS.
>
> But in the case of NSS_STATUS_NOTFOUND, no NSS module sets errno,
> so the return value is a random value, but should be zero.
>
> Who should set errno in this case? Should all NSS modules set
> errno? Or should we explicit return 0 in the getXXbyYY_r functions
> for NSS_STATUS_NOTFOUND?
Looking at getXXbyYY_r.c, we can only change it in this file.
My proposed fix:
2004-03-27 Thorsten Kukuk <kukuk@suse.de>
* nss/getXXbyYY_r.c: If key is not found, return zero, not
a random errno value.
--- nss/getXXbyYY_r.c 10 Mar 2004 09:28:25 -0000 1.57
+++ nss/getXXbyYY_r.c 27 Mar 2004 08:44:52 -0000
@@ -256,6 +256,11 @@
else if (status == NSS_STATUS_TRYAGAIN && *h_errnop != NETDB_INTERNAL)
res = EAGAIN;
#endif
+ else if (status == NSS_STATUS_NOTFOUND)
+ {
+ __set_errno (ENOENT);
+ return 0;
+ }
else
return errno;
--
Thorsten Kukuk http://www.suse.de/~kukuk/ kukuk@suse.de
SuSE Linux AG Maxfeldstr. 5 D-90409 Nuernberg
--------------------------------------------------------------------
Key fingerprint = A368 676B 5E1B 3E46 CFCE 2D97 F8FD 4E23 56C6 FB4B
next prev parent reply other threads:[~2004-03-27 17:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-27 17:53 Thorsten Kukuk
2004-03-29 20:16 ` Thorsten Kukuk [this message]
2004-03-30 0:01 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040327175122.GA21826@suse.de \
--to=kukuk@suse.de \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).