public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Kaz Kojima <kkojima@rr.iij4u.or.jp>
To: libc-hacker@sources.redhat.com
Subject: [PATCH] Fix SH linuxthreads vfork
Date: Thu, 22 Apr 2004 06:39:00 -0000	[thread overview]
Message-ID: <20040422.153713.34742469.kkojima@rr.iij4u.or.jp> (raw)

Hi,

I'd like to forward a mail from SUGIOKA Toshinobu because he has
a trouble with subscribing libc-hacker.
I've confirmed his patch below in my environment.

BTW, does anyone know about any trouble to subscribe libc-hacker?

Regards,
	kaz
--
Hi,

Appended patch fixes segmentation fault in vfork on sh[34]-linux target
which is caused by un-initialized register usage.

ChangeLog:
2004-04-22  SUGIOKA Toshinobu <sugioka@itonet.co.jp>

	* linuxthreads/sysdeps/unix/sysv/linux/sh/vfork.S: Fix wrong function
	pointer reference in PIC case.

Index: linuxthreads/sysdeps/unix/sysv/linux/sh/vfork.S
===================================================================
RCS file: /cvs/glibc/libc/linuxthreads/sysdeps/unix/sysv/linux/sh/vfork.S,v
retrieving revision 1.3
diff -u -r1.3 vfork.S
--- linuxthreads/sysdeps/unix/sysv/linux/sh/vfork.S	11 Feb 2003 06:27:54 -0000	1.3
+++ linuxthreads/sysdeps/unix/sysv/linux/sh/vfork.S	22 Apr 2004 05:10:49 -0000
@@ -1,4 +1,4 @@
-/* Copyright (C) 2003 Free Software Foundation, Inc.
+/* Copyright (C) 2003, 2004 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -27,8 +27,11 @@
 
 ENTRY (__vfork)
 #ifdef SHARED
+	mov.l	.Lgot, r1
+	mova	.Lgot, r0
+	add	r0, r1
 	mov.l	.Lpthread_func, r0
-	mov.l	@(r0,r12), r0
+	mov.l	@(r0,r1), r0
 #else
 	mov.l	.Lpthread_create, r0
 #endif
@@ -50,6 +53,8 @@
 .L1:	.word	__NR_vfork
 	.align	2
 #ifdef SHARED
+.Lgot:
+	.long	_GLOBAL_OFFSET_TABLE_
 .Lpthread_func:
 	.long	__libc_pthread_functions@GOTOFF
 #else

             reply	other threads:[~2004-04-22  6:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-22  6:39 Kaz Kojima [this message]
2004-04-22  6:51 ` Ulrich Drepper
2004-04-22  7:07   ` Kaz Kojima

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040422.153713.34742469.kkojima@rr.iij4u.or.jp \
    --to=kkojima@rr.iij4u.or.jp \
    --cc=libc-hacker@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).