public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>,
	"M.H.VanLeeuwen" <vanl@megsinet.net>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix [BZ #139] (followup)
Date: Thu, 29 Apr 2004 17:34:00 -0000	[thread overview]
Message-ID: <20040429152159.GU5191@sunsite.ms.mff.cuni.cz> (raw)
In-Reply-To: <4090FF37.11B1A8A1@megsinet.net>

On Thu, Apr 29, 2004 at 08:12:23AM -0500, M.H.VanLeeuwen wrote:
> Jakub,
> 
> Could you also check qp_qtoui.c
...
> What about qp_qtoux.c
...
> And qp_qtox.c

Obviously you're right.  This patch is needed in addition to the previous
one.

2004-04-29  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/sparc/sparc64/soft-fp/qp_qtoui.c (_Qp_qtoui): Use %f31
	for single precision register, add it to __asm clobbers.
	* sysdeps/sparc/sparc64/soft-fp/qp_qtoux.c (_Qp_qtoux): Use fqtox
	instead of fqtoi in QP_HANDLE_EXCEPTIONS.
	* sysdeps/sparc/sparc64/soft-fp/qp_qtox.c (_Qp_qtox): Likewise.
	Reported by M. H. VanLeeuwen <vanl@megsinet.net>.

--- libc/sysdeps/sparc/sparc64/soft-fp/qp_qtoui.c.jj	2001-07-06 06:56:05.000000000 +0200
+++ libc/sysdeps/sparc/sparc64/soft-fp/qp_qtoui.c	2004-04-29 15:15:11.942798201 +0200
@@ -1,6 +1,6 @@
 /* Software floating-point emulation.
    Return (unsigned int)(*a)
-   Copyright (C) 1997,1999 Free Software Foundation, Inc.
+   Copyright (C) 1997, 1999, 2004 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
    Contributed by Richard Henderson (rth@cygnus.com) and
 		  Jakub Jelinek (jj@ultra.linux.cz).
@@ -38,9 +38,9 @@ unsigned int _Qp_qtoui(const long double
   	__asm (
 "	ldd [%1], %%f52\n"
 "	ldd [%1+8], %%f54\n"
-"	fqtoi %%f52, %%f60\n"
-"	st %%f60, [%0]\n"
-"	" : : "r" (&rx), "r" (a) : QP_CLOBBER);
+"	fqtoi %%f52, %%f31\n"
+"	st %%f31, [%0]\n"
+"	" : : "r" (&rx), "r" (a) : QP_CLOBBER, "f31");
 	r = rx);
 
   return r;
--- libc/sysdeps/sparc/sparc64/soft-fp/qp_qtoux.c.jj	2001-07-06 06:56:05.000000000 +0200
+++ libc/sysdeps/sparc/sparc64/soft-fp/qp_qtoux.c	2004-04-29 15:16:37.753419820 +0200
@@ -1,6 +1,6 @@
 /* Software floating-point emulation.
    Return (unsigned long)(*a)
-   Copyright (C) 1997,1999 Free Software Foundation, Inc.
+   Copyright (C) 1997, 1999, 2004 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
    Contributed by Richard Henderson (rth@cygnus.com) and
 		  Jakub Jelinek (jj@ultra.linux.cz).
@@ -38,7 +38,7 @@ unsigned long _Qp_qtoux(const long doubl
   	__asm (
 "	ldd [%1], %%f52\n"
 "	ldd [%1+8], %%f54\n"
-"	fqtoi %%f52, %%f60\n"
+"	fqtox %%f52, %%f60\n"
 "	std %%f60, [%0]\n"
 "	" : : "r" (&rx), "r" (a) : QP_CLOBBER);
 	r = rx);
--- libc/sysdeps/sparc/sparc64/soft-fp/qp_qtox.c.jj	2001-07-06 06:56:05.000000000 +0200
+++ libc/sysdeps/sparc/sparc64/soft-fp/qp_qtox.c	2004-04-29 15:16:57.549872038 +0200
@@ -1,6 +1,6 @@
 /* Software floating-point emulation.
    Return (long)(*a)
-   Copyright (C) 1997,1999 Free Software Foundation, Inc.
+   Copyright (C) 1997, 1999, 2004 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
    Contributed by Richard Henderson (rth@cygnus.com) and
 		  Jakub Jelinek (jj@ultra.linux.cz).
@@ -38,7 +38,7 @@ long _Qp_qtox(const long double *a)
   	__asm (
 "	ldd [%1], %%f52\n"
 "	ldd [%1+8], %%f54\n"
-"	fqtoi %%f52, %%f60\n"
+"	fqtox %%f52, %%f60\n"
 "	std %%f60, [%0]\n"
 "	" : : "r" (&rx), "r" (a) : QP_CLOBBER);
 	r = rx);


	Jakub

  parent reply	other threads:[~2004-04-29 17:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-29  7:38 [PATCH] Fix [BZ #139] Jakub Jelinek
     [not found] ` <4090FF37.11B1A8A1@megsinet.net>
2004-04-29 17:34   ` Jakub Jelinek [this message]
2004-04-29 20:02     ` [PATCH] Fix [BZ #139] (followup) Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040429152159.GU5191@sunsite.ms.mff.cuni.cz \
    --to=jakub@redhat.com \
    --cc=drepper@redhat.com \
    --cc=libc-hacker@sources.redhat.com \
    --cc=vanl@megsinet.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).