public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix typo in add_dependency
Date: Tue, 25 May 2004 12:49:00 -0000	[thread overview]
Message-ID: <20040524091426.GQ5191@sunsite.ms.mff.cuni.cz> (raw)

Hi!

The code was mistakenly setting DF_BIND_NOW (8) in l_flags
instead of DF_1_NODELETE (8) in l_flags_1.

2004-05-24  Jakub Jelinek  <jakub@redhat.com>

	* elf/dl-lookup.c (add_dependency): Set DF_1_NODELETE bit
	in l_flags_1, not in l_flags.

--- libc/elf/dl-lookup.c.jj	2004-05-18 10:52:24.000000000 +0200
+++ libc/elf/dl-lookup.c	2004-05-24 13:24:12.624800758 +0200
@@ -108,7 +108,7 @@ add_dependency (struct link_map *undef_m
       || (undef_map->l_flags_1 & DF_1_NODELETE) != 0)
     {
       ++map->l_opencount;
-      map->l_flags |= DF_1_NODELETE;
+      map->l_flags_1 |= DF_1_NODELETE;
       goto out;
     }
 

	Jakub

             reply	other threads:[~2004-05-24 11:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-25 12:49 Jakub Jelinek [this message]
2004-05-26  4:21 ` Ulrich Drepper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040524091426.GQ5191@sunsite.ms.mff.cuni.cz \
    --to=jakub@redhat.com \
    --cc=drepper@redhat.com \
    --cc=libc-hacker@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).