From: Thorsten Kukuk <kukuk@suse.de>
To: Steve Munroe <sjmunroe@us.ibm.com>
Cc: Jakub Jelinek <jakub@redhat.com>, libc-hacker@sources.redhat.com
Subject: Re: deadlock in signal handler with NPTL
Date: Wed, 23 Jun 2004 06:56:00 -0000 [thread overview]
Message-ID: <20040623065635.GA21813@suse.de> (raw)
In-Reply-To: <OFE6CF76BD.5785A8CC-ON86256EBC.00194B07-86256EBC.0019CA90@us.ibm.com>
On Tue, Jun 22, Steve Munroe wrote:
> Thorsten Kukuk <kukuk@suse.de> wrote on 06/22/2004 11:22:56 PM:
>
> > On Tue, Jun 22, Jakub Jelinek wrote:
> >
> > > On Tue, Jun 22, 2004 at 11:50:59PM +0200, Thorsten Kukuk wrote:
> > > >
> > > > Hi,
> > > >
> > > > I got the following test program. I know, it is very ugly and there
> > > > are a lot of things somebody should not do, but this is something
> > > > what programs like sshd are doing.
> > >
> > > Then they should be fixed. Neither syslog, nor printf, nor fflush
> > > are supposed to be async-signal safe, nor they actually are in glibc.
> >
> > Yes, but the problem is: Nearly every daemon on a Linux system is
> > calling syslog() in a signal handler and it seems to be very easy
> > to deadlock them on every Linux system running glibc/NPTL. While
> > there seems to be no other system with the same problem.
> >
>
> Then what has change from glibc-2.3.3 (RHEL 3) until now? Because I have
> not seen this problem before.
The test case also deadlocks on a RHEL 3 machine very fast.
> I have reviewed all the changes to
> lowlevellock.h since and I do not see any change that would effect this. In
> fact your test case should show that same hang there.
The difference is: glibc with linuxthreads compiled only uses the
locking, if the program is linked against pthread.
glibc with NPTL compiled always uses locking (__libc_lock_lock always
calls lll_lock).
Uli, Jakub, is this really necessary? Wouldn't it be better to add the
one extra compare?
> Have the daemon's changed recently to add the syslog() call to the signal
> handler?
No, this is very, very old.
Thorsten
--
Thorsten Kukuk http://www.suse.de/~kukuk/ kukuk@suse.de
SuSE Linux AG Maxfeldstr. 5 D-90409 Nuernberg
--------------------------------------------------------------------
Key fingerprint = A368 676B 5E1B 3E46 CFCE 2D97 F8FD 4E23 56C6 FB4B
next prev parent reply other threads:[~2004-06-23 6:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-22 21:51 Thorsten Kukuk
2004-06-22 22:07 ` Jakub Jelinek
2004-06-23 4:26 ` Thorsten Kukuk
2004-06-23 4:41 ` Steve Munroe
2004-06-23 6:56 ` Thorsten Kukuk [this message]
2004-06-23 8:23 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040623065635.GA21813@suse.de \
--to=kukuk@suse.de \
--cc=jakub@redhat.com \
--cc=libc-hacker@sources.redhat.com \
--cc=sjmunroe@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).