From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18510 invoked by alias); 15 Jul 2004 22:05:14 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 18458 invoked from network); 15 Jul 2004 22:05:07 -0000 Received: from unknown (HELO sunsite.ms.mff.cuni.cz) (195.113.15.26) by sourceware.org with SMTP; 15 Jul 2004 22:05:07 -0000 Received: from sunsite.ms.mff.cuni.cz (sunsite.mff.cuni.cz [127.0.0.1]) by sunsite.ms.mff.cuni.cz (8.12.8/8.12.8) with ESMTP id i6FJnO3j032517; Thu, 15 Jul 2004 21:49:24 +0200 Received: (from jakub@localhost) by sunsite.ms.mff.cuni.cz (8.12.8/8.12.8/Submit) id i6FJnOIP032515; Thu, 15 Jul 2004 21:49:24 +0200 Date: Thu, 15 Jul 2004 22:05:00 -0000 From: Jakub Jelinek To: Roland McGrath Cc: Ulrich Drepper , Glibc hackers Subject: Re: [PATCH] Allow main to come from a shared library for PIE [BZ #262] Message-ID: <20040715194924.GE30497@sunsite.ms.mff.cuni.cz> Reply-To: Jakub Jelinek References: <20040715103304.GA30497@sunsite.ms.mff.cuni.cz> <200407152202.i6FM2jKk020602@magilla.sf.frob.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200407152202.i6FM2jKk020602@magilla.sf.frob.com> User-Agent: Mutt/1.4.1i X-SW-Source: 2004-07/txt/msg00033.txt.bz2 On Thu, Jul 15, 2004 at 03:02:45PM -0700, Roland McGrath wrote: > > +ifeq (yesyes,$(have-fpie)$(build-shared)) > > +tests: $(objpfx)tst-pie1.out > > +endif > > This should be tests += tst-pie1. No, when it is tests += tst-pie1, the elf/Makefile $(objpfx)/tst-pie1 rule is overriding the default one. I used tests += tst-pie1 initially but changed it afterwards. Maybe if we have more PIE tests in the future the Makefiles could have some common rule how to build them, but for one test I think what the patch does is enough. Jakub