From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>, Roland McGrath <roland@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix strtold on 32-bit arches with ldbl-96 [BZ #274]
Date: Tue, 20 Jul 2004 22:17:00 -0000 [thread overview]
Message-ID: <20040720200152.GO30497@sunsite.ms.mff.cuni.cz> (raw)
Hi!
This hunk is supposed to shift retval up by used bits
where used >= BITS_PER_MP_LIMB, but it clears also the lowest
limb already containing result of mpn_lshift.
2004-07-21 Jakub Jelinek <jakub@redhat.com>
[BZ #274]
* stdlib/strtod_l.c (INTERNAL (__STRTOF)): Fix used >=
BITS_PER_MP_LIMB shifting up.
* stdlib/tst-strtod.c (main): Add new tests.
--- libc/stdlib/strtod_l.c.jj 2004-07-12 20:47:47.000000000 +0200
+++ libc/stdlib/strtod_l.c 2004-07-20 23:49:29.456044788 +0200
@@ -1488,7 +1488,7 @@
/ BITS_PER_MP_LIMB],
retval, RETURN_LIMB_SIZE,
used % BITS_PER_MP_LIMB);
- for (i = used / BITS_PER_MP_LIMB; i >= 0; --i)
+ for (i = used / BITS_PER_MP_LIMB - 1; i >= 0; --i)
retval[i] = 0;
}
else if (used > 0)
--- libc/stdlib/tst-strtod.c.jj 2003-06-27 13:08:48.000000000 +0200
+++ libc/stdlib/tst-strtod.c 2004-07-21 00:02:05.378630841 +0200
@@ -157,6 +157,21 @@ main (int argc, char ** argv)
status = 1;
}
+ static struct { const char *str; long double l; } ltests[] =
+ {
+ { "42.0000000000000000001", 42.0000000000000000001L },
+ { "42.00000000000000000001", 42.00000000000000000001L },
+ { "42.000000000000000000001", 42.000000000000000000001L }
+ };
+ int n;
+ for (n = 0; n < sizeof (ltests) / sizeof (ltests[0]); ++n)
+ if (strtold (ltests[n].str, NULL) != ltests[n].l)
+ {
+ printf ("ltests[%d]: %La != %La\n", n,
+ strtold (ltests[n].str, NULL), ltests[n].l);
+ status = 1;
+ }
+
status |= long_dbl ();
status |= locale_test ();
Jakub
next reply other threads:[~2004-07-20 22:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-20 22:17 Jakub Jelinek [this message]
2004-07-25 3:32 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040720200152.GO30497@sunsite.ms.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).