From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26837 invoked by alias); 11 Aug 2004 18:42:18 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 26809 invoked from network); 11 Aug 2004 18:42:17 -0000 Received: from unknown (HELO gateway.sf.frob.com) (64.81.54.130) by sourceware.org with SMTP; 11 Aug 2004 18:42:17 -0000 Received: from magilla.sf.frob.com (magilla.sf.frob.com [198.49.250.228]) by gateway.sf.frob.com (Postfix) with ESMTP id 74C58357B; Wed, 11 Aug 2004 11:42:16 -0700 (PDT) Received: from magilla.sf.frob.com (localhost.localdomain [127.0.0.1]) by magilla.sf.frob.com (8.12.11/8.12.9) with ESMTP id i7BIgGtA014549; Wed, 11 Aug 2004 11:42:16 -0700 Received: (from roland@localhost) by magilla.sf.frob.com (8.12.11/8.12.11/Submit) id i7BIgFV9014546; Wed, 11 Aug 2004 11:42:15 -0700 Date: Wed, 11 Aug 2004 18:42:00 -0000 Message-Id: <200408111842.i7BIgFV9014546@magilla.sf.frob.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Jakub Jelinek Cc: Ulrich Drepper , Glibc hackers Subject: Re: [PATCH] Fix tzfile.c In-Reply-To: Jakub Jelinek's message of Wednesday, 11 August 2004 15:58:07 +0200 <20040811135807.GW30497@sunsite.ms.mff.cuni.cz> X-Zippy-Says: Now, I think it would be GOOD to buy FIVE or SIX STUDEBAKERS and CRUISE for ARTIFICIAL FLAVORING!! X-SW-Source: 2004-08/txt/msg00034.txt.bz2 > Still, I wonder if it is a good idea to fopen /etc/localtime every time > strfime, strftime_l or mktime is called or if it wouldn't be enough to > use the old behaviour of tzset (where if $TZ is unset and was previously > unset too, nothing will happen) when called from these functions and > only do the slow path if tzset () is called by the user program. This is why tzset exists. I don't thik mktime et al ought to be rechecking this.