From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] nscd fixes
Date: Thu, 16 Sep 2004 15:10:00 -0000 [thread overview]
Message-ID: <20040916151043.GG30497@sunsite.ms.mff.cuni.cz> (raw)
Hi!
a) allow nscd to even compile on x86-64 (missing -fpie)
b) get rid of newly introduced munmap .plt slot
2004-09-16 Jakub Jelinek <jakub@redhat.com>
* nscd/nscd_helper.c (__nscd_unmap, get_mapping): Use __munmap
instead of munmap.
* nscd/Makefile (CFLAGS-aicache.c): Set to -fpie.
--- libc/nscd/nscd_helper.c.jj 2004-09-14 00:32:54.000000000 +0200
+++ libc/nscd/nscd_helper.c 2004-09-16 17:07:23.384149635 +0200
@@ -72,7 +72,7 @@ void
__nscd_unmap (struct mapped_database *mapped)
{
assert (mapped->counter == 0);
- munmap ((void *) mapped->head, mapped->mapsize);
+ __munmap ((void *) mapped->head, mapped->mapsize);
free (mapped);
}
@@ -180,7 +180,7 @@ get_mapping (request_type type, const ch
if (newp == NULL)
{
/* Ugh, after all we went through the memory allocation failed. */
- munmap (result, size);
+ __munmap (result, size);
goto out_close;
}
--- libc/nscd/Makefile.jj 2004-09-16 11:38:00.000000000 +0200
+++ libc/nscd/Makefile 2004-09-16 17:03:40.685497693 +0200
@@ -82,6 +82,7 @@ CFLAGS-xmalloc.c = -fpie
CFLAGS-xstrdup.c = -fpie
CFLAGS-mem.c = -fpie
CFLAGS-nscd_setup_thread.c = -fpie
+CFLAGS-aicache.c = -fpie
$(objpfx)nscd: $(addprefix $(objpfx),$(nscd-modules:=.o))
$(LINK.o) -pie -Wl,-O1 \
Jakub
reply other threads:[~2004-09-16 15:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040916151043.GG30497@sunsite.ms.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).