From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-hacker-return-7949-listarch-libc-hacker=sources.redhat.com@sources.redhat.com>
Received: (qmail 23812 invoked by alias); 25 Sep 2004 10:07:01 -0000
Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:libc-hacker-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/libc-hacker/>
List-Post: <mailto:libc-hacker@sources.redhat.com>
List-Help: <mailto:libc-hacker-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: libc-hacker-owner@sources.redhat.com
Received: (qmail 23784 invoked from network); 25 Sep 2004 10:06:59 -0000
Received: from unknown (HELO gateway.sf.frob.com) (64.81.54.130)
  by sourceware.org with SMTP; 25 Sep 2004 10:06:59 -0000
Received: from magilla.sf.frob.com (magilla.sf.frob.com [198.49.250.228])
	by gateway.sf.frob.com (Postfix) with ESMTP
	id 005FB357B; Sat, 25 Sep 2004 03:06:57 -0700 (PDT)
Received: from magilla.sf.frob.com (localhost.localdomain [127.0.0.1])
	by magilla.sf.frob.com (8.12.11/8.12.9) with ESMTP id i8PA6u7D012153;
	Sat, 25 Sep 2004 03:06:56 -0700
Received: (from roland@localhost)
	by magilla.sf.frob.com (8.12.11/8.12.11/Submit) id i8PA6uoX012150;
	Sat, 25 Sep 2004 03:06:56 -0700
Date: Sat, 25 Sep 2004 10:07:00 -0000
Message-Id: <200409251006.i8PA6uoX012150@magilla.sf.frob.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
From: Roland McGrath <roland@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Ulrich Drepper <drepper@redhat.com>,
	Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: [PATCH] Add multiple inclusion guards to useldt.h
In-Reply-To: Jakub Jelinek's message of  Saturday, 25 September 2004 10:10:40 +0200 <20040925081040.GR30497@sunsite.ms.mff.cuni.cz>
X-Antipastobozoticataclysm: 
   When George Bush projectile vomits antipasto on the Japanese.
X-SW-Source: 2004-09/txt/msg00100.txt.bz2

> >From reading the code, I believe i686 --with-tls linuxthreads
> are now broken.

Ack!  You're right.  The report was about i586 being broken, and I tested
that and failed to go back and test the i686 build.  It's even worse than
you thought, though!  useldt.h gets included once before USE_TLS is set and
once after, changing how it defines things.  So plain multiple inclusion
protection would in fact break it.  I put in another tweak and now I think
both builds are ok again.


Thanks,
Roland