From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Shut up a warning in sysconf.c
Date: Tue, 07 Dec 2004 20:48:00 -0000 [thread overview]
Message-ID: <20041207204807.GE5149@sunsite.mff.cuni.cz> (raw)
Hi!
On ia64 I get:
../sysdeps/posix/sysconf.c:1215: warning: '__sysconf_check_spec' defined but not used
The following patch seems to cure it.
I tried __attribute__((unused)) first but for some reason that still warned
(maybe compiler bug). __attribute_used__ is not something that is desirable
in this case, as there is no point in actually having the routine if it will
be never used.
2004-12-07 Jakub Jelinek <jakub@redhat.com>
* sysdeps/posix/sysconf.c (__sysconf_check_spec): Only define
if it will be actually used.
--- libc/sysdeps/posix/sysconf.c.jj 2004-12-07 15:42:04.000000000 -0500
+++ libc/sysdeps/posix/sysconf.c 2004-12-07 15:50:38.000000000 -0500
@@ -34,7 +34,12 @@
#include <regex.h>
+#if !defined _XBS5_ILP32_OFF32 || !defined _XBS5_ILP32_OFFBIG \
+ || !defined _XBS5_LP64_OFF64 || !defined _XBS5_LPBIG_OFFBIG \
+ || !defined _POSIX_V6_ILP32_OFF32 || !defined _POSIX_V6_ILP32_OFFBIG \
+ || !defined _POSIX_V6_LP64_OFF64 || !defined _POSIX_V6_LPBIG_OFFBIG
static long int __sysconf_check_spec (const char *spec);
+#endif
/* Get the value of the system variable NAME. */
@@ -1210,6 +1215,10 @@ __sysconf (name)
weak_alias (__sysconf, sysconf)
libc_hidden_def (__sysconf)
+#if !defined _XBS5_ILP32_OFF32 || !defined _XBS5_ILP32_OFFBIG \
+ || !defined _XBS5_LP64_OFF64 || !defined _XBS5_LPBIG_OFFBIG \
+ || !defined _POSIX_V6_ILP32_OFF32 || !defined _POSIX_V6_ILP32_OFFBIG \
+ || !defined _POSIX_V6_LP64_OFF64 || !defined _POSIX_V6_LPBIG_OFFBIG
static long int
__sysconf_check_spec (const char *spec)
{
@@ -1230,3 +1239,4 @@ __sysconf_check_spec (const char *spec)
__set_errno (save_errno);
return ret;
}
+#endif
Jakub
next reply other threads:[~2004-12-07 20:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-07 20:48 Jakub Jelinek [this message]
2004-12-07 20:54 ` Roland McGrath
2004-12-07 21:03 ` [PATCH] Shut up a warning in sysconf.c (take 2) Jakub Jelinek
2004-12-07 21:06 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041207204807.GE5149@sunsite.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).