From: "H. J. Lu" <hjl@lucon.org>
To: Andreas Jaeger <aj@suse.de>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: Fix sunrpc/xcrypt.c for GCC 4.0
Date: Sun, 19 Dec 2004 20:59:00 -0000 [thread overview]
Message-ID: <20041219205945.GB29877@lucon.org> (raw)
In-Reply-To: <m33by285ha.fsf@gromit.moeb>
On Sun, Dec 19, 2004 at 08:15:13PM +0100, Andreas Jaeger wrote:
>
> Ok to commit the appended patch to fix xcrypt with GCC 4.0? This is
> similar to a patch by Alexandre for getnetgrent_r.
>
> Andreas
>
> 2004-12-19 Andreas Jaeger <aj@suse.de>
>
> [BZ #573]
> * sunrpc/xcrypt.c (passwd2des_internal): Make it hidden instead of
> internal linkage.
>
> ============================================================
> Index: sunrpc/xcrypt.c
> --- sunrpc/xcrypt.c 17 Sep 2002 10:58:00 -0000 1.7
> +++ sunrpc/xcrypt.c 19 Dec 2004 15:13:10 -0000
> @@ -69,13 +69,15 @@ static char hexval (char) internal_funct
>
> static void hex2bin (int, char *, char *) internal_function;
> static void bin2hex (int, unsigned char *, char *) internal_function;
> -static void passwd2des_internal (char *pw, char *key);
> -
> +void passwd2des_internal (char *pw, char *key);
> +#ifdef _LIBC
> +libc_hidden_proto (passwd2des_internal)
> +#endif
>
> /*
> * Turn password into DES key
> */
> -static void
> +void
> passwd2des_internal (char *pw, char *key)
> {
> int i;
> @@ -88,6 +90,7 @@ passwd2des_internal (char *pw, char *key
> }
>
> #ifdef _LIBC
> +libc_hidden_def (passwd2des_internal)
> strong_alias (passwd2des_internal, passwd2des)
> #else
> void passwd2des (char *pw, char *key)
This patch will make gcc not to inline passwd2des_internal which
is the correct thing to do. Marking passwd2des_internal as "used"
will support inlining passwd2des_internal.
H.J.
prev parent reply other threads:[~2004-12-19 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-19 19:26 Andreas Jaeger
2004-12-19 20:33 ` Roland McGrath
2004-12-19 20:59 ` H. J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041219205945.GB29877@lucon.org \
--to=hjl@lucon.org \
--cc=aj@suse.de \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).