From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-hacker-return-8185-listarch-libc-hacker=sources.redhat.com@sources.redhat.com>
Received: (qmail 26369 invoked by alias); 7 Jan 2005 12:44:27 -0000
Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:libc-hacker-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/libc-hacker/>
List-Post: <mailto:libc-hacker@sources.redhat.com>
List-Help: <mailto:libc-hacker-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: libc-hacker-owner@sources.redhat.com
Received: (qmail 26342 invoked from network); 7 Jan 2005 12:44:26 -0000
Received: from unknown (HELO sunsite.mff.cuni.cz) (195.113.15.26)
  by sourceware.org with SMTP; 7 Jan 2005 12:44:26 -0000
Received: from sunsite.mff.cuni.cz (sunsite.mff.cuni.cz [127.0.0.1])
	by sunsite.mff.cuni.cz (8.13.1/8.13.1) with ESMTP id j07CiQ59002133;
	Fri, 7 Jan 2005 13:44:26 +0100
Received: (from jj@localhost)
	by sunsite.mff.cuni.cz (8.13.1/8.13.1/Submit) id j07CiPYp002130;
	Fri, 7 Jan 2005 13:44:25 +0100
Date: Fri, 07 Jan 2005 12:44:00 -0000
From: Jakub Jelinek <jakub@redhat.com>
To: Andreas Jaeger <aj@suse.de>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: Fixes for make clean
Message-ID: <20050107124425.GB17169@sunsite.mff.cuni.cz>
Reply-To: Jakub Jelinek <jakub@redhat.com>
References: <m3sm5ibwe5.fsf@gromit.moeb>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3sm5ibwe5.fsf@gromit.moeb>
User-Agent: Mutt/1.4.1i
X-SW-Source: 2005-01/txt/msg00003.txt.bz2

On Mon, Jan 03, 2005 at 12:10:58PM +0100, Andreas Jaeger wrote:
> 2005-01-03  Andreas Jaeger  <aj@suse.de>
> 
> 	* elf/Makefile (tests): Change rule for tst-pie1 so that make
> 	clean works.
> 
> --- elf/Makefile	27 Oct 2004 20:26:47 -0000	1.287
> +++ elf/Makefile	3 Jan 2005 11:10:36 -0000
> @@ -1,4 +1,4 @@
> -# Copyright (C) 1995-2002, 2003, 2004 Free Software Foundation, Inc.
> +# Copyright (C) 1995-2004, 2005 Free Software Foundation, Inc.
>  # This file is part of the GNU C Library.
>  
>  # The GNU C Library is free software; you can redistribute it and/or
> @@ -163,7 +163,7 @@ tests-nodlopen-yes = nodlopen nodlopen2
>  tests-execstack-yes = tst-execstack tst-execstack-needed tst-execstack-prog
>  endif
>  ifeq (yesyes,$(have-fpie)$(build-shared))
> -tests: $(objpfx)tst-pie1.out
> +tests += tst-pie1
>  endif
>  modules-names = testobj1 testobj2 testobj3 testobj4 testobj5 testobj6 \
>  		testobj1_1 failobj constload2 constload3 unloadmod \

This change is bad:
make[2]: Entering directory
`/usr/src/build/502950-i686/BUILD/glibc-20050106T2203/elf' Makefile:726: warning: overriding commands for target `/usr/src/build/502950-i686/BUILD/glibc-20050106T2203/build-i686-linux/elf/tst-pie1'
../Rules:118: warning: ignoring old commands for target `/usr/src/build/502950-i686/BUILD/glibc-20050106T2203/build-i686-linux/elf/tst-pie1'
mkdir /usr/src/build/502950-i686/BUILD/glibc-20050106T2203/build-i686-linux/elf

I think putting tst-pie1.out and tst-pie1 into generated instead would cure
this.

	Jakub