From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>, Andreas Jaeger <aj@suse.de>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fixes for make clean (take 2)
Date: Sat, 08 Jan 2005 16:39:00 -0000 [thread overview]
Message-ID: <20050108163855.GD17169@sunsite.mff.cuni.cz> (raw)
In-Reply-To: <m3brc12veq.fsf@gromit.moeb>
On Fri, Jan 07, 2005 at 02:58:21PM +0100, Andreas Jaeger wrote:
> > This change is bad:
> > make[2]: Entering directory
> > `/usr/src/build/502950-i686/BUILD/glibc-20050106T2203/elf' Makefile:726: warning: overriding commands for target `/usr/src/build/502950-i686/BUILD/glibc-20050106T2203/build-i686-linux/elf/tst-pie1'
> > ../Rules:118: warning: ignoring old commands for target `/usr/src/build/502950-i686/BUILD/glibc-20050106T2203/build-i686-linux/elf/tst-pie1'
> > mkdir /usr/src/build/502950-i686/BUILD/glibc-20050106T2203/build-i686-linux/elf
> >
> > I think putting tst-pie1.out and tst-pie1 into generated instead would cure
> > this.
>
> I'll revert my patch now,
This seems to work for me:
2005-01-08 Jakub Jelinek <jakub@redhat.com>
* elf/Makefile (generated): Add tst-pie1{,.out,.o}.
--- libc/elf/Makefile.jj 2005-01-08 16:50:21.000000000 +0100
+++ libc/elf/Makefile 2005-01-08 17:24:04.000000000 +0100
@@ -734,6 +734,8 @@ $(objpfx)tst-pie1: $(objpfx)tst-pie1.o $
-L$(subst :, -L,$(rpath-link)) -Wl,-rpath-link=$(rpath-link) \
-o $@ $(objpfx)tst-pie1.o $(objpfx)tst-piemod1.so \
$(common-objpfx)libc_nonshared.a
+
+generated += tst-pie1 tst-pie1.out tst-pie1.o
endif
check-textrel-CFLAGS = -O -Wall -D_XOPEN_SOURCE=600 -D_BSD_SOURCE
Jakub
next prev parent reply other threads:[~2005-01-08 16:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-03 11:11 Fixes for make clean Andreas Jaeger
2005-01-03 16:57 ` Ulrich Drepper
2005-01-07 12:44 ` Jakub Jelinek
2005-01-07 13:58 ` Andreas Jaeger
2005-01-08 16:39 ` Jakub Jelinek [this message]
2005-01-08 16:49 ` [PATCH] Fixes for make clean (take 2) Andreas Jaeger
2005-01-08 17:04 ` Jakub Jelinek
2005-01-08 17:13 ` Andreas Jaeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050108163855.GD17169@sunsite.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=aj@suse.de \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).