public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* Fix warnings in bits/link.h
@ 2005-01-09 10:03 Andreas Jaeger
  2005-01-22 22:19 ` Richard Henderson
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Jaeger @ 2005-01-09 10:03 UTC (permalink / raw)
  To: Glibc hackers

[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]


With GCC 4 CVS I get lots of:

../sysdeps/x86_64/bits/link.h:66: warning: use __attribute__ ((vector_size)) instead

Is the appended patch the right thing to do?

Andreas

2005-01-09  Andreas Jaeger  <aj@suse.de>

	* sysdeps/x86_64/bits/link.h: Use vector_size for GCC 4.0.

============================================================
Index: sysdeps/x86_64/bits/link.h
--- sysdeps/x86_64/bits/link.h	6 Jan 2005 22:40:14 -0000	1.3
+++ sysdeps/x86_64/bits/link.h	9 Jan 2005 10:02:49 -0000
@@ -63,7 +63,12 @@ __END_DECLS
 #else
 
 /* Registers for entry into PLT on x86-64.  */
+# if __GNUC_PREREQ (4,0)
+typedef float La_x86_64_xmm __attribute__ ((vector_size (16)));
+# else
 typedef float La_x86_64_xmm __attribute__ ((__mode__ (__V4SF__)));
+# endif
+
 typedef struct La_x86_64_regs
 {
   uint64_t lr_rdx;

-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Fix warnings in bits/link.h
  2005-01-09 10:03 Fix warnings in bits/link.h Andreas Jaeger
@ 2005-01-22 22:19 ` Richard Henderson
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2005-01-22 22:19 UTC (permalink / raw)
  To: Andreas Jaeger; +Cc: Glibc hackers

On Sun, Jan 09, 2005 at 11:03:28AM +0100, Andreas Jaeger wrote:
> +# if __GNUC_PREREQ (4,0)
> +typedef float La_x86_64_xmm __attribute__ ((vector_size (16)));
> +# else
>  typedef float La_x86_64_xmm __attribute__ ((__mode__ (__V4SF__)));
> +# endif

If you're going to be namespace-safe, you should use __vector_size__.


r~

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-01-22 22:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-09 10:03 Fix warnings in bits/link.h Andreas Jaeger
2005-01-22 22:19 ` Richard Henderson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).