From: Jakub Jelinek <jakub@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Ulrich Drepper <drepper@redhat.com>,
Roland McGrath <roland@redhat.com>,
Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: [PATCH] Fix build with GCC 4
Date: Sat, 05 Mar 2005 14:53:00 -0000 [thread overview]
Message-ID: <20050305145325.GM4777@sunsite.mff.cuni.cz> (raw)
In-Reply-To: <jebr9ycgif.fsf@sykes.suse.de>
On Sat, Mar 05, 2005 at 03:30:00PM +0100, Andreas Schwab wrote:
> Jakub Jelinek <jakub@redhat.com> writes:
>
> > --- libc/sysdeps/i386/dl-machine.h.jj 2005-02-16 20:16:33.000000000 -0500
> > +++ libc/sysdeps/i386/dl-machine.h 2005-03-04 16:50:32.313591897 -0500
> > @@ -301,9 +301,7 @@ elf_machine_plt_value (struct link_map *
> >
> > /* The i386 never uses Elf32_Rela relocations for the dynamic linker.
> > Prelinked libraries may use Elf32_Rela though. */
> > -#ifdef RTLD_BOOTSTRAP
> > -# define ELF_MACHINE_NO_RELA 1
> > -#endif
> > +#define ELF_MACHINE_NO_RELA (defined RTLD_BOOTSTRAP)
>
> Does gcc guarantee that this works (which would be an extension wrt the C
> standard)?
It certainly works with all GCC's I've tried: 2.96-RH, 3.2.3, 3.3.4, 3.4.3,
4.0 branch, HEAD.
And because this is an internal header, if it stops working in some future
compiler version, then we can change it.
FYI, glibc already uses this in _G_config.h:
$ find . -name \*.[chS] | xargs grep _G_HAVE_ST_BLKSIZE
./sysdeps/gnu/_G_config.h:#define _G_HAVE_ST_BLKSIZE defined (_STATBUF_ST_BLKSIZE)
./sysdeps/generic/_G_config.h:#define _G_HAVE_ST_BLKSIZE defined (_STATBUF_ST_BLKSIZE)
./sysdeps/mach/hurd/_G_config.h:#define _G_HAVE_ST_BLKSIZE defined (_STATBUF_ST_BLKSIZE)
./libio/libio.h:#define _IO_HAVE_ST_BLKSIZE _G_HAVE_ST_BLKSIZE
$ find . -name \*.[chS] | xargs grep _IO_HAVE_ST_BLKSIZE
./libio/wfiledoalloc.c:#if _IO_HAVE_ST_BLKSIZE
./libio/libio.h:#define _IO_HAVE_ST_BLKSIZE _G_HAVE_ST_BLKSIZE
./libio/filedoalloc.c:#if _IO_HAVE_ST_BLKSIZE
Jakub
next prev parent reply other threads:[~2005-03-05 14:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-05 9:21 Jakub Jelinek
2005-03-05 14:30 ` Andreas Schwab
2005-03-05 14:53 ` Jakub Jelinek [this message]
2005-03-06 21:23 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050305145325.GM4777@sunsite.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
--cc=roland@redhat.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).