From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4034 invoked by alias); 5 Mar 2005 14:53:29 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 4018 invoked from network); 5 Mar 2005 14:53:29 -0000 Received: from unknown (HELO sunsite.mff.cuni.cz) (195.113.15.26) by sourceware.org with SMTP; 5 Mar 2005 14:53:29 -0000 Received: from sunsite.mff.cuni.cz (sunsite.mff.cuni.cz [127.0.0.1]) by sunsite.mff.cuni.cz (8.13.1/8.13.1) with ESMTP id j25ErQOa022571; Sat, 5 Mar 2005 15:53:26 +0100 Received: (from jj@localhost) by sunsite.mff.cuni.cz (8.13.1/8.13.1/Submit) id j25ErQoq022570; Sat, 5 Mar 2005 15:53:26 +0100 Date: Sat, 05 Mar 2005 14:53:00 -0000 From: Jakub Jelinek To: Andreas Schwab Cc: Ulrich Drepper , Roland McGrath , Glibc hackers Subject: Re: [PATCH] Fix build with GCC 4 Message-ID: <20050305145325.GM4777@sunsite.mff.cuni.cz> Reply-To: Jakub Jelinek References: <20050305092049.GJ4777@sunsite.mff.cuni.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-SW-Source: 2005-03/txt/msg00013.txt.bz2 On Sat, Mar 05, 2005 at 03:30:00PM +0100, Andreas Schwab wrote: > Jakub Jelinek writes: > > > --- libc/sysdeps/i386/dl-machine.h.jj 2005-02-16 20:16:33.000000000 -0500 > > +++ libc/sysdeps/i386/dl-machine.h 2005-03-04 16:50:32.313591897 -0500 > > @@ -301,9 +301,7 @@ elf_machine_plt_value (struct link_map * > > > > /* The i386 never uses Elf32_Rela relocations for the dynamic linker. > > Prelinked libraries may use Elf32_Rela though. */ > > -#ifdef RTLD_BOOTSTRAP > > -# define ELF_MACHINE_NO_RELA 1 > > -#endif > > +#define ELF_MACHINE_NO_RELA (defined RTLD_BOOTSTRAP) > > Does gcc guarantee that this works (which would be an extension wrt the C > standard)? It certainly works with all GCC's I've tried: 2.96-RH, 3.2.3, 3.3.4, 3.4.3, 4.0 branch, HEAD. And because this is an internal header, if it stops working in some future compiler version, then we can change it. FYI, glibc already uses this in _G_config.h: $ find . -name \*.[chS] | xargs grep _G_HAVE_ST_BLKSIZE ./sysdeps/gnu/_G_config.h:#define _G_HAVE_ST_BLKSIZE defined (_STATBUF_ST_BLKSIZE) ./sysdeps/generic/_G_config.h:#define _G_HAVE_ST_BLKSIZE defined (_STATBUF_ST_BLKSIZE) ./sysdeps/mach/hurd/_G_config.h:#define _G_HAVE_ST_BLKSIZE defined (_STATBUF_ST_BLKSIZE) ./libio/libio.h:#define _IO_HAVE_ST_BLKSIZE _G_HAVE_ST_BLKSIZE $ find . -name \*.[chS] | xargs grep _IO_HAVE_ST_BLKSIZE ./libio/wfiledoalloc.c:#if _IO_HAVE_ST_BLKSIZE ./libio/libio.h:#define _IO_HAVE_ST_BLKSIZE _G_HAVE_ST_BLKSIZE ./libio/filedoalloc.c:#if _IO_HAVE_ST_BLKSIZE Jakub