public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix tst-mallocfork
Date: Mon, 28 Nov 2005 12:45:00 -0000	[thread overview]
Message-ID: <20051128124515.GX16723@sunsite.mff.cuni.cz> (raw)

Hi!

As detected by valgrind, sa_flags was uninitialized when calling
sigaction.  Fixed thusly.

2005-11-28  Jakub Jelinek  <jakub@redhat.com>

	* malloc/tst-mallocfork.c (do_test): Make sure sa_flags is
	initialized.  Reported by John Reiser <jreiser@BitWagon.com>.

--- libc/malloc/tst-mallocfork.c.jj	2005-09-27 07:42:06.000000000 +0200
+++ libc/malloc/tst-mallocfork.c	2005-11-28 13:28:48.000000000 +0100
@@ -22,9 +22,8 @@ do_test (void)
 {
   pid_t parent = getpid ();
 
-  struct sigaction action;
+  struct sigaction action = { .sa_handler = sig_handler };
   sigemptyset (&action.sa_mask);
-  action.sa_handler = sig_handler;
 
   malloc (sizeof (int));
 

	Jakub

                 reply	other threads:[~2005-11-28 12:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051128124515.GX16723@sunsite.mff.cuni.cz \
    --to=jakub@redhat.com \
    --cc=drepper@redhat.com \
    --cc=libc-hacker@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).