From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29746 invoked by alias); 21 Dec 2005 00:57:09 -0000 Received: (qmail 29694 invoked by uid 22791); 21 Dec 2005 00:57:08 -0000 X-Spam-Check-By: sourceware.org Received: from mo00.iij4u.or.jp (HELO mo00.iij4u.or.jp) (210.130.0.19) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 21 Dec 2005 00:57:06 +0000 Received: MO(mo00) for id jBL0v30Y028765; Wed, 21 Dec 2005 09:57:03 +0900 (JST) Received: from localhost (30.30.30.125.dy.iij4u.or.jp [125.30.30.30]) by r-rr.iij4u.or.jp (4U-MR/r-rr) id jBL0v3m9015937 for ; Wed, 21 Dec 2005 09:57:03 +0900 (JST) Date: Wed, 21 Dec 2005 00:57:00 -0000 Message-Id: <20051221.095702.63058592.kkojima@rr.iij4u.or.jp> To: libc-hacker@sources.redhat.com Subject: Re: things to do for arch maintainers From: Kaz Kojima In-Reply-To: <43A823AA.5010007@redhat.com> References: <43A5B402.10007@redhat.com> <20051220.180924.32716879.kkojima@rr.iij4u.or.jp> <43A823AA.5010007@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2005-12/txt/msg00036.txt.bz2 Ulrich Drepper wrote: > Applied. But why didn't the typo have any effect? Is there a test we > need to add? Before the patch, sysdeps/generic/dl-sysdep.h wasn't included before the definitions of SYSCALL_ERROR_HANDLER in sysdeps/unix/sysv/linux/sh/ sysdeps.h. Then RTLD_PRIVATE_ERRNO is always 0 and the broken macro was never used. So rtld-* routines used slow SYSCALL_ERROR_HANDLER but there was no error. Now the patch includes sysdeps/generic/dl-sysdep.h via tls.h and the fast SYSCALL_ERROR_HANDLER is used. Regards, kaz