From: Jakub Jelinek <jakub@redhat.com>
To: Roland McGrath <roland@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix tst-faccessat.c if run as root
Date: Sun, 15 Jan 2006 20:14:00 -0000 [thread overview]
Message-ID: <20060115201442.GE4625@sunsite.mff.cuni.cz> (raw)
Hi!
While it is generally a bad idea to run glibc testsuite as root (and I
usually don't do that either), other tests test for this condition too.
2006-01-15 Jakub Jelinek <jakub@redhat.com>
* io/tst-faccessat.c (do_test): Don't fail if getuid () == 0.
--- libc/io/tst-faccessat.c.jj 2006-01-06 13:14:18.000000000 +0100
+++ libc/io/tst-faccessat.c 2006-01-15 21:10:20.000000000 +0100
@@ -134,8 +134,9 @@ do_test (void)
}
errno = 0;
- if (faccessat (dir_fd, "some-file", W_OK, AT_EACCESS) == 0
- || errno != EACCES)
+ if (getuid () != 0
+ && (faccessat (dir_fd, "some-file", W_OK, AT_EACCESS) == 0
+ || errno != EACCES))
{
printf ("faccessat W_OK on unwritable file: %m\n");
result = 1;
Jakub
reply other threads:[~2006-01-15 20:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060115201442.GE4625@sunsite.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=libc-hacker@sources.redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).