From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-hacker-return-8833-listarch-libc-hacker=sources.redhat.com@sourceware.org>
Received: (qmail 4161 invoked by alias); 1 Feb 2006 15:29:39 -0000
Received: (qmail 4145 invoked by uid 22791); 1 Feb 2006 15:29:38 -0000
X-Spam-Check-By: sourceware.org
Received: from sunsite.ms.mff.cuni.cz (HELO sunsite.mff.cuni.cz) (195.113.15.26)
    by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 01 Feb 2006 15:29:36 +0000
Received: from sunsite.mff.cuni.cz (sunsite.mff.cuni.cz [127.0.0.1])
	by sunsite.mff.cuni.cz (8.13.1/8.13.1) with ESMTP id k11FTR8x017284;
	Wed, 1 Feb 2006 16:29:27 +0100
Received: (from jj@localhost)
	by sunsite.mff.cuni.cz (8.13.1/8.13.1/Submit) id k11FTQ7T017283;
	Wed, 1 Feb 2006 16:29:26 +0100
Date: Wed, 01 Feb 2006 15:29:00 -0000
From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>, Roland McGrath <roland@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: [PATCH] Fix <bits/mathcalls.h> __BEGIN_NAMESPACE_C99/__END_NAMESPACE_C99 pairing
Message-ID: <20060201152926.GA4625@sunsite.mff.cuni.cz>
Reply-To: Jakub Jelinek <jakub@redhat.com>
References: <20060201152453.GZ4625@sunsite.mff.cuni.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060201152453.GZ4625@sunsite.mff.cuni.cz>
User-Agent: Mutt/1.4.1i
Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:libc-hacker-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-hacker/>
List-Post: <mailto:libc-hacker@sourceware.org>
List-Help: <mailto:libc-hacker-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-hacker-owner@sourceware.org
X-SW-Source: 2006-02/txt/msg00004.txt.bz2

On Wed, Feb 01, 2006 at 04:24:53PM +0100, Jakub Jelinek wrote:
> 2006-02-01  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* math/bits/mathcalls.h: Guard __END_NAMESPACE_C99 with the
> 	same #if condition as corresponding __BEGIN_NAMESPACE_C99.
> 	(scalb): Don't define only if __USE_ISOC99.

Forgot to add, I did some testing to see if similar problems aren't
elsewhere:
#!/bin/sh
for i in `rpm -ql glibc-headers`; do perl /usr/src/libc/scripts/begin-end-check.pl $i; done 2>&1 | grep -v OK
for i in `rpm -ql glibc-headers`; do
cat > /tmp/a.c <<EOF
#include <features.h>
#undef __BEGIN_DECLS
#undef __END_DECLS
#undef __BEGIN_NAMESPACE_STD
#undef __END_NAMESPACE_STD
#undef __BEGIN_NAMESPACE_C99
#undef __END_NAMESPACE_C99
#include <$i>
EOF
gcc -E /tmp/a.c -o /tmp/a.i > /dev/null 2>&1 || continue;
for flags in "" -D_GNU_SOURCE -D_ISOC99_SOURCE -D_XOPEN_SOURCE -D_XOPEN_SOURCE_EXTENDED -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_SVID_SOURCE -D_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -D_XOPEN_SOURCE=500 -D_XOPEN_SOURCE=600 -D_BSD_SOURCE -ansi -D_POSIX_SOURCE -D_POSIX_C_SOURCE -D_POSIX_C_SOURCE=2 -D_POSIX_C_SOURCE=199309L -D_POSIX_C_SOURCE=199506L -D_POSIX_C_SOURCE=200112L; do
gcc $flags -E /tmp/a.c -o /tmp/a.i > /dev/null 2>&1;
perl /usr/src/libc/scripts/begin-end-check.pl /tmp/a.i | grep -v OK | sed "s~^~$i $flags: ~"
done
done

and math.h (plus tgmath.h that includes math.h) were the only 2 reported
headers.

	Jakub