From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4381 invoked by alias); 2 Feb 2006 10:15:53 -0000 Received: (qmail 4323 invoked by uid 22791); 2 Feb 2006 10:15:50 -0000 X-Spam-Check-By: sourceware.org Received: from gateway.sf.frob.com (HELO gateway.sf.frob.com) (64.81.54.130) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 02 Feb 2006 10:15:47 +0000 Received: from magilla.sf.frob.com (magilla.sf.frob.com [198.49.250.228]) by gateway.sf.frob.com (Postfix) with ESMTP id BAC03357B; Thu, 2 Feb 2006 02:15:44 -0800 (PST) Received: by magilla.sf.frob.com (Postfix, from userid 5281) id 476E1180988; Thu, 2 Feb 2006 02:15:44 -0800 (PST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Thorsten Kukuk Cc: libc-hacker@sources.redhat.com Subject: Re: __atfct_seterrno() or futimesat() broken In-Reply-To: Thorsten Kukuk's message of Saturday, 28 January 2006 17:55:11 +0100 <20060128165511.GA4000@suse.de> X-Antipastobozoticataclysm: When George Bush projectile vomits antipasto on the Japanese. Message-Id: <20060202101544.476E1180988@magilla.sf.frob.com> Date: Thu, 02 Feb 2006 10:15:00 -0000 Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00010.txt.bz2 I don't see how the lstat check that did the problematic string twiddling was actually doing anything for us not better done by the fstat check for the EBADF case. I changed it to use the simple fstat check for EBADF on ENOENT as well as ENOTDIR, which gets rid of the code with the bad assumptions about the contents of BUF. I also made it do the check for missing /proc on ENOENT as well. There are in fact many other potential error codes that could be /proc is not mounted as expected, but ENOENT is in fact the most likely one (and ENOTDIR possible, but not perhaps any more likely than several others). Thanks, Roland