From: "David S. Miller" <davem@davemloft.net>
To: drepper@redhat.com
Cc: libc-hacker@sources.redhat.com
Subject: Re: [PATCH]: Sparc SUN4V Niagara optimized memset/memcpy
Date: Wed, 01 Mar 2006 21:19:00 -0000 [thread overview]
Message-ID: <20060301.131949.48296326.davem@davemloft.net> (raw)
In-Reply-To: <4405C2B7.4070005@redhat.com>
From: Ulrich Drepper <drepper@redhat.com>
Date: Wed, 01 Mar 2006 07:50:15 -0800
> David S. Miller wrote:
>
> > +ENTRY(memset)
> > + /* %o0=buf, %o1=pat, %o2=len */
> > + and %o1, 0xff, %o3
> > + mov %o2, %o1
> > + sllx %o3, 8, %g1
> > + or %g1, %o3, %o2
> > + sllx %o2, 16, %g1
> > + or %g1, %o2, %o2
> > + sllx %o2, 32, %g1
> > + ba,pt %XCC, 1f
> > + or %g1, %o2, %o2
> > +
> > +ENTRY(__bzero)
>
> This is confusing data. No two functions should overlap. I suggest to
> make bzero a little function calling memset similar to what you did with
> bcopy.
That's a waste of cycles and I-cache usage, for what gain?
I don't see why a function cannot have an alternate entry like this.
next prev parent reply other threads:[~2006-03-01 21:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-01 8:55 David S. Miller
2006-03-01 15:49 ` Ulrich Drepper
2006-03-01 21:19 ` David S. Miller [this message]
2006-03-01 21:30 ` Ulrich Drepper
2006-03-01 22:25 ` David S. Miller
2006-03-01 22:31 ` Jakub Jelinek
2006-03-01 22:48 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060301.131949.48296326.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).