From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6963 invoked by alias); 2 Mar 2006 18:30:44 -0000 Received: (qmail 6947 invoked by uid 22791); 2 Mar 2006 18:30:44 -0000 X-Spam-Check-By: sourceware.org Received: from smtp104.sbc.mail.mud.yahoo.com (HELO smtp104.sbc.mail.mud.yahoo.com) (68.142.198.203) by sourceware.org (qpsmtpd/0.31) with SMTP; Thu, 02 Mar 2006 18:30:42 +0000 Received: (qmail 75644 invoked from network); 2 Mar 2006 18:30:41 -0000 Received: from unknown (HELO lucon.org) (hjjean@sbcglobal.net@71.146.76.164 with login) by smtp104.sbc.mail.mud.yahoo.com with SMTP; 2 Mar 2006 18:30:40 -0000 Received: by lucon.org (Postfix, from userid 1000) id 67E1D63F49; Thu, 2 Mar 2006 10:30:39 -0800 (PST) Date: Thu, 02 Mar 2006 18:30:00 -0000 From: "H. J. Lu" To: Ulrich Drepper Cc: Jakub Jelinek , Roland McGrath , Glibc hackers Subject: Re: [PATCH] Avoid check-testrel failing on all sparc*, alpha or ppc32 -mbss-plt shared libraries Message-ID: <20060302183039.GA29439@lucon.org> References: <20060302145442.GN30252@sunsite.mff.cuni.cz> <440716AF.5070601@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <440716AF.5070601@redhat.com> User-Agent: Mutt/1.4.2.1i Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00022.txt.bz2 On Thu, Mar 02, 2006 at 08:00:47AM -0800, Ulrich Drepper wrote: > I've applied the patch but this really cannot be a long-term solution. > Either the arch goes away or it gets an ABI which isn't an open > invitation for attackers. >=20 It is broken since elf/check-textrel.c is compiled with cd /export/build/gnu/glibc-nptl-4.1-redhat/build-x86_64-linux/elf && gcc -p= ipe -O -Wall -D_XOPEN_SOURCE=3D600 -D_BSD_SOURCE -include ../config.h /exp= ort/gnu/src/glibc/libc/elf/check-textrel.c -o check-textrel /export/gnu/src/glibc/libc/elf/check-textrel.c:21:20: error: config.h: No such file or directory There is no need to include "config.h" since there is "-include ../config.h" already. This patch fixes it. H.J. ---- 2006-03-02 H.J. Lu * elf/check-textrel.c: Don't include "config.h". --- elf/check-textrel.c.foo 2006-03-02 09:17:08.000000000 -0800 +++ elf/check-textrel.c 2006-03-02 10:14:10.000000000 -0800 @@ -18,7 +18,6 @@ Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA. */ =20 -#include "config.h" #include #include #include